From: Ivan Warren <ivan@vmfacility.fr>
To: linux-kernel@vger.kernel.org
Subject: [Patch 2.6] s390 - Allow ECKD devices to be used with older controllers and emulation
Date: Fri, 08 Aug 2008 20:46:44 +0200 [thread overview]
Message-ID: <489C9494.9070504@vmfacility.fr> (raw)
Crowd,
Apologies if this is not formatted correctly, but I'm fairly new to this
(submitting patches that is)..
**************
s390 dasd ECKD drivers issues a Perform Subsystem Function / Prepare
for Read SubSystem Data with a length of 16.
However, older hardware and documentation specifies a length of 12
leading to a possible Incorrect Length indication.
This patch activates the SLI CCW flag in order to avoid reporting
the Incorrect Length indication since it is possible that the DASD
control unit may be expecting a length of 12, not 16.
-- Ivan Warren (ivan@vmfacility.fr)
diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index 773b3fe..c4e3935 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -810,6 +810,7 @@ static int dasd_eckd_read_features(struct
dasd_device *device)
ccw->cmd_code = DASD_ECKD_CCW_PSF;
ccw->count = sizeof(struct dasd_psf_prssd_data);
ccw->flags |= CCW_FLAG_CC;
+ ccw->flags |= CCW_FLAG_SLI;
ccw->cda = (__u32)(addr_t) prssdp;
/* Read Subsystem Data - feature codes */
**************
--Ivan
next reply other threads:[~2008-08-08 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 18:46 Ivan Warren [this message]
2008-08-13 23:07 ` Fwd: [Patch 2.6] s390 - Allow ECKD devices to be used with older controllers and emulation Frans Pop
2008-08-14 15:07 ` Martin Schwidefsky
2008-08-14 18:26 ` [PATCH] S390 : Set SLI on PSF/PRSSD on Dasd ECKD initialisation Ivan Warren
2008-08-15 14:15 ` Stefan Weinhuber
2008-08-18 17:08 ` Ivan Warren
2008-08-18 17:56 ` Frans Pop
2008-08-21 16:32 ` Stefan Weinhuber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489C9494.9070504@vmfacility.fr \
--to=ivan@vmfacility.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox