public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Mark McLoughlin <markmc@redhat.com>,
	xen-devel@lists.xensource.com,
	Eduardo Habkost <ehabkost@redhat.com>,
	Stephen Tweedie <sct@redhat.com>,
	linux-kernel@vger.kernel.org, Simon Horman <horms@verge.net.au>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	Dhaval Giani <dhaval@linux.vnet.ibm.com>
Subject: [PATCH] x86: work around gcc 3.4.x bug
Date: Fri, 08 Aug 2008 13:46:07 -0700	[thread overview]
Message-ID: <489CB08F.9030902@goop.org> (raw)
In-Reply-To: <20080808183711.GA14495@cs181140183.pp.htv.fi>

gcc-3.4.x crashes when compiling pgd_prepopulate_pmd() when
PREALLOCATED_PMDS == 0 and CONFIG_DEBUG_INFO is enabled.  This seems
to avoid the problem.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Adrian Bunk <bunk@kernel.org>
Cc: Simon Horman <horms@verge.net.au>
Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>
---
 arch/x86/mm/pgtable.c |    3 +++
 1 file changed, 3 insertions(+)

===================================================================
--- a/arch/x86/mm/pgtable.c
+++ b/arch/x86/mm/pgtable.c
@@ -207,6 +207,9 @@
 	unsigned long addr;
 	int i;
 
+	if (PREALLOCATED_PMDS == 0) /* Work around gcc-3.4.x bug */
+		return;
+
 	pud = pud_offset(pgd, 0);
 
  	for (addr = i = 0; i < PREALLOCATED_PMDS;



  reply	other threads:[~2008-08-08 20:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  5:04 Allow compile with CONFIG_DEBUG_INFO=y, X86_PAE not set on gcc 3.4.5 Simon Horman
2008-08-08  6:37 ` Jeremy Fitzhardinge
2008-08-08  7:50   ` Simon Horman
2008-08-08  8:01   ` Adrian Bunk
2008-08-08 15:21     ` [Xen-devel] " Jeremy Fitzhardinge
2008-08-08 16:13       ` Adrian Bunk
2008-08-08 18:01         ` Jeremy Fitzhardinge
2008-08-08 18:37           ` Adrian Bunk
2008-08-08 20:46             ` Jeremy Fitzhardinge [this message]
2008-08-09  6:29               ` [PATCH] x86: work around gcc 3.4.x bug Simon Horman
2008-08-11 16:44                 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489CB08F.9030902@goop.org \
    --to=jeremy@goop.org \
    --cc=bunk@kernel.org \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=ehabkost@redhat.com \
    --cc=horms@verge.net.au \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markmc@redhat.com \
    --cc=mingo@elte.hu \
    --cc=sct@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox