Re: + x86-kill-arch-x86-kernel-mpparsec-debugging-printk.patch added to -mm tree

Re: + x86-kill-arch-x86-kernel-mpparsec-debugging-printk.patch added to -mm tree

[Yinghai Lu]

On Fri, Aug 8, 2008 at 1:51 PM,  <akpm@linux-foundation.org> wrote:
>
> The patch titled
>     x86: kill arch/x86/kernel/mpparse.c debugging printk
> has been added to the -mm tree.  Its filename is
>     x86-kill-arch-x86-kernel-mpparsec-debugging-printk.patch
>
> Before you just go and hit "reply", please:
>   a) Consider who else should be cc'ed
>   b) Prefer to cc a suitable mailing list as well
>   c) Ideally: find the original patch on the mailing list and do a
>      reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
> out what to do about this
>
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
>
> ------------------------------------------------------
> Subject: x86: kill arch/x86/kernel/mpparse.c debugging printk
> From: Rene Herman <rene.herman@keyaccess.nl>
>
> commit 11a62a056093a7f25f1595fbd8bd5f93559572b6 turns some formerly nopped
> debugging printks in arch/x86/kernel/mppparse.c into regular ones.  The
> one at the top of smp_scan_config() in particular also prints on
> !CONFIG_SMP/CONFIG_X86_LOCAL_APIC kernels and UP machines without anything
> resembling MP tables which makes their lowly UP owners wonder...
>
> Given that it was up to this point also not considered valuable user-level
> information, let's just kill that one.
>
> Signed-off-by: Rene Herman <rene.herman@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>  arch/x86/kernel/mpparse.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff -puN arch/x86/kernel/mpparse.c~x86-kill-arch-x86-kernel-mpparsec-debugging-printk arch/x86/kernel/mpparse.c
> --- a/arch/x86/kernel/mpparse.c~x86-kill-arch-x86-kernel-mpparsec-debugging-printk
> +++ a/arch/x86/kernel/mpparse.c
> @@ -697,7 +697,6 @@ static int __init smp_scan_config(unsign
>        unsigned int *bp = phys_to_virt(base);
>        struct intel_mp_floating *mpf;
>
> -       printk(KERN_DEBUG "Scan SMP from %p for %ld bytes.\n", bp, length);
>        BUILD_BUG_ON(sizeof(*mpf) != 16);
>
>        while (length > 0) {
> _
>
> Patches currently in -mm which might be from rene.herman@keyaccess.nl are
>
> x86-kill-arch-x86-kernel-mpparsec-debugging-printk.patch
> i2c-dont-autograb-i2c-pca-is.patch
>
why?  that just three lines debug debug info.

YH

Re: + x86-kill-arch-x86-kernel-mpparsec-debugging-printk.patch added to -mm tree

[Andrew Morton]

On Fri, 8 Aug 2008 14:13:29 -0700
"Yinghai Lu" <yhlu.kernel@gmail.com> wrote:

> > commit 11a62a056093a7f25f1595fbd8bd5f93559572b6 turns some formerly nopped
> > debugging printks in arch/x86/kernel/mppparse.c into regular ones.  The
> > one at the top of smp_scan_config() in particular also prints on
> > !CONFIG_SMP/CONFIG_X86_LOCAL_APIC kernels and UP machines without anything
> > resembling MP tables which makes their lowly UP owners wonder...
> >
> > Given that it was up to this point also not considered valuable user-level
> > information, let's just kill that one.
> >
>
> why?  that just three lines debug debug info.

For the reasons described in the changelog text.  They look quite valid
to me.

Re: + x86-kill-arch-x86-kernel-mpparsec-debugging-printk.patch added to -mm tree

[Yinghai Lu]

On Fri, Aug 8, 2008 at 2:28 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 8 Aug 2008 14:13:29 -0700
> "Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
>
>> > commit 11a62a056093a7f25f1595fbd8bd5f93559572b6 turns some formerly nopped
>> > debugging printks in arch/x86/kernel/mppparse.c into regular ones.  The
>> > one at the top of smp_scan_config() in particular also prints on
>> > !CONFIG_SMP/CONFIG_X86_LOCAL_APIC kernels and UP machines without anything
>> > resembling MP tables which makes their lowly UP owners wonder...
>> >
>> > Given that it was up to this point also not considered valuable user-level
>> > information, let's just kill that one.
>> >
>>
>> why?  that just three lines debug debug info.
>
> For the reasons described in the changelog text.  They look quite valid
> to me.

then how about system do have mptable ?

YH

Re: + x86-kill-arch-x86-kernel-mpparsec-debugging-printk.patch added to -mm tree

[Rene Herman]

On 08-08-08 23:44, Yinghai Lu wrote:

> On Fri, Aug 8, 2008 at 2:28 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
>> On Fri, 8 Aug 2008 14:13:29 -0700
>> "Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
>>
>>>> commit 11a62a056093a7f25f1595fbd8bd5f93559572b6 turns some formerly nopped
>>>> debugging printks in arch/x86/kernel/mppparse.c into regular ones.  The
>>>> one at the top of smp_scan_config() in particular also prints on
>>>> !CONFIG_SMP/CONFIG_X86_LOCAL_APIC kernels and UP machines without anything
>>>> resembling MP tables which makes their lowly UP owners wonder...
>>>>
>>>> Given that it was up to this point also not considered valuable user-level
>>>> information, let's just kill that one.
>>>>
>>> why?  that just three lines debug debug info.
>> For the reasons described in the changelog text.  They look quite valid
>> to me.
> 
> then how about system do have mptable ?

Those print:

   printk(KERN_INFO "found SMP MP-table at [%p] %08lx\n",
                                  mpf, virt_to_phys(mpf));

a few lines down. Note moreover that is used to be a "Dprintk()" which 
was defined to <nop> before -- ie, no change.

Rene.