From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755240AbYHIFZZ (ORCPT ); Sat, 9 Aug 2008 01:25:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750845AbYHIFZN (ORCPT ); Sat, 9 Aug 2008 01:25:13 -0400 Received: from terminus.zytor.com ([198.137.202.10]:38244 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbYHIFZM (ORCPT ); Sat, 9 Aug 2008 01:25:12 -0400 Message-ID: <489D2A2F.7060206@zytor.com> Date: Fri, 08 Aug 2008 22:25:03 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Rene Herman CC: Bjorn Helgaas , Linux Kernel , Andrew Morton Subject: Re: [PATCH] PNP: make the resource type an unsigned long References: <489BEA31.3040101@keyaccess.nl> <489CC0DD.5010402@zytor.com> <489D2954.9090309@keyaccess.nl> In-Reply-To: <489D2954.9090309@keyaccess.nl> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rene Herman wrote: >> >> Seems a bit pointless ... either one of those flags is >= 32 bits, in >> which case we need u64, or it's not, in which case there is no reason >> to burden the output with bits we don't need. > > Yes, it's a not a functional patch -- only a type-consistency one. Right > now we're mixing ints (signed ones even) and unsigned longs and while in > this case that's not a functional problem it's messy and inconsistent. > > I agree (as Andrew said earlier as well) that the struct resource flags > member should probably just be a u32 but it's not. Changing that would > be a bigger change than just a simple conistency thing. > You're going in the wrong direction for consistency. long is different on 32 and 64 bits, and really should be avoided unless that is intended. -hpa