From: Benny Halevy <bhalevy@panasas.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Adrian Bunk <bunk@kernel.org>,
neilb@suse.de, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [2.6 patch] uninline nfsd4_op_name()
Date: Mon, 11 Aug 2008 11:47:44 +0300 [thread overview]
Message-ID: <489FFCB0.7080509@panasas.com> (raw)
In-Reply-To: <20080811030339.GA5621@fieldses.org>
On Aug. 11, 2008, 6:03 +0300, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> On Sun, Aug 10, 2008 at 02:32:31PM +0300, Benny Halevy wrote:
>> Linus Torvalds wrote:
>>> On Fri, 8 Aug 2008, Adrian Bunk wrote:
>>>> There doesn't seem to be a compelling reason why nfsd4_op_name() is
>>>> marked as "inline":
>> Agreed.
>>
>>> It should also return a "const char *", I think.
>>>
>>> Since it does.
>> Right.
>
> OK, I modified that to add "const" as Linus suggests, and applied to
>
> git://linux-nfs.org/~bfields/linux.git for-2.6.27
>
> Thanks to everyone.
>
> --b.
Bruce, Linus already corrected and merged Adrian's patch in
linux-2.6/master as commit f1c7f79b6ab4f7ada002a0fae47f462ede6b6857
Benny
next prev parent reply other threads:[~2008-08-11 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 16:26 [2.6 patch] uninline nfsd4_op_name() Adrian Bunk
2008-08-08 18:25 ` Linus Torvalds
2008-08-10 11:32 ` Benny Halevy
2008-08-11 3:03 ` J. Bruce Fields
2008-08-11 8:47 ` Benny Halevy [this message]
2008-08-11 15:39 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489FFCB0.7080509@panasas.com \
--to=bhalevy@panasas.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox