Re: [PATCH] x86: kill arch/x86/kernel/mpparse.c debugging printk.

Ingo Molnar
2008-08-11T12:20:58Z

* Rene Herman <rene.herman@keyaccess.nl> wrote:

> Hi Andrew.
>
> <repeat below changelog>
>
> Rene.

> >From 00acea21e579ea0853baba25420f373ea83533a3 Mon Sep 17 00:00:00 2001
> From: Rene Herman <rene.herman@keyaccess.nl>
> Date: Thu, 7 Aug 2008 01:50:35 +0200
> Subject: [PATCH] x86: kill arch/x86/kernel/mpparse.c debugging printk.
>
> commit 11a62a056093a7f25f1595fbd8bd5f93559572b6 turns some formerly
> nopped debugging printks in arch/x86/kernel/mppparse.c into regular
> ones. The one at the top of smp_scan_config() in particular also
> prints on !CONFIG_SMP/CONFIG_X86_LOCAL_APIC kernels and UP machines
> without anything resembling MP tables which makes their lowly UP
> owners wonder...
>
> given that it was up to this point also not considered valuable
> user-level information, let's just kill that one.

hm, i found it useful in the past in about 2-3 cases.

How about a patch that makes the printout depend on apic=debug ? That
way the message can still be there in case of bugreports that somehow
deal with SMP or APIC bugs (without having to recompile the kernel).

The way to make the printout depend on apic=debug/verbose is to do
something like this:

apic_printk(APIC_VERBOSE, "Scan SMP from %p for %ld bytes.\n", bp, length);

Would you mind to send a patch for that?

Thanks,

Ingo