Re: [PATCH] x86: kill arch/x86/kernel/mpparse.c debugging printk.

Ingo Molnar
2008-08-11T16:39:27Z

* Rene Herman <rene.herman@keyaccess.nl> wrote:

>> The way to make the printout depend on apic=debug/verbose is to do
>> something like this:
>>
>> apic_printk(APIC_VERBOSE, "Scan SMP from %p for %ld bytes.\n", bp, length);
>>
>> Would you mind to send a patch for that?
>
> I wouldn't. Like this? This turns the printk's that used to be
> Dprintk's into apic_printk's.

applied to tip/x86/urgent - thanks Rene.

> I am myself only interested in the one at the top of smp_scan_config()
> (it made me think I had misconfigured something upon all of a sudden
> seeing SMP printk's on my UP machine on 2.6.27-rc) but I guess this is
> the more complete version.
>
> One problem; on 32-bit, "apic=" is a __setup() param and isn't
> actually early enough for us here so this needs it turned into an
> early_param() (followup).

good spotting, applied that one to tip/x86/urgent as well - thanks.

Ingo