* [PATCH] trace: Fix some mistakes in error messages
@ 2008-08-11 22:06 Frédéric Weisbecker
2008-08-14 13:13 ` Frédéric Weisbecker
0 siblings, 1 reply; 6+ messages in thread
From: Frédéric Weisbecker @ 2008-08-11 22:06 UTC (permalink / raw)
To: mingo, srostedt; +Cc: Linux Kernel
This patch fixes some mistakes on the tracer in warning messages when
debugfs fails to create tracing files.
Kernel version: 2.6.27-rc1
Regards.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
diff -rup a/kernel/trace/trace.c b/kernel/trace/trace.c
--- a/kernel/trace/trace.c 2008-08-11 22:44:25.000000000 +0200
+++ b/kernel/trace/trace.c 2008-08-11 23:10:39.000000000 +0200
@@ -2881,12 +2881,12 @@ static __init void tracer_init_debugfs(v
entry = debugfs_create_file("available_tracers", 0444, d_tracer,
&global_trace, &show_traces_fops);
if (!entry)
- pr_warning("Could not create debugfs 'trace' entry\n");
+ pr_warning("Could not create debugfs 'available_tracers' entry\n");
entry = debugfs_create_file("current_tracer", 0444, d_tracer,
&global_trace, &set_tracer_fops);
if (!entry)
- pr_warning("Could not create debugfs 'trace' entry\n");
+ pr_warning("Could not create debugfs 'current_tracer' entry\n");
entry = debugfs_create_file("tracing_max_latency", 0644, d_tracer,
&tracing_max_latency,
@@ -2899,7 +2899,7 @@ static __init void tracer_init_debugfs(v
&tracing_thresh, &tracing_max_lat_fops);
if (!entry)
pr_warning("Could not create debugfs "
- "'tracing_threash' entry\n");
+ "'tracing_thresh' entry\n");
entry = debugfs_create_file("README", 0644, d_tracer,
NULL, &tracing_readme_fops);
if (!entry)
@@ -2909,13 +2909,13 @@ static __init void tracer_init_debugfs(v
NULL, &tracing_pipe_fops);
if (!entry)
pr_warning("Could not create debugfs "
- "'tracing_threash' entry\n");
+ "'trace_pipe' entry\n");
entry = debugfs_create_file("trace_entries", 0644, d_tracer,
&global_trace, &tracing_entries_fops);
if (!entry)
pr_warning("Could not create debugfs "
- "'tracing_threash' entry\n");
+ "'trace_entries' entry\n");
#ifdef CONFIG_DYNAMIC_FTRACE
entry = debugfs_create_file("dyn_ftrace_total_info", 0444, d_tracer,
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] trace: Fix some mistakes in error messages
@ 2008-08-11 22:07 Frédéric Weisbecker
2008-08-15 12:59 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Frédéric Weisbecker @ 2008-08-11 22:07 UTC (permalink / raw)
To: mingo, srostedt; +Cc: Linux Kernel
This patch fixes some mistakes on the tracer in warning messages when
debugfs fails to create tracing files.
Kernel version: 2.6.27-rc1
Regards.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
diff -rup a/kernel/trace/trace.c b/kernel/trace/trace.c
--- a/kernel/trace/trace.c 2008-08-11 22:44:25.000000000 +0200
+++ b/kernel/trace/trace.c 2008-08-11 23:10:39.000000000 +0200
@@ -2881,12 +2881,12 @@ static __init void tracer_init_debugfs(v
entry = debugfs_create_file("available_tracers", 0444, d_tracer,
&global_trace, &show_traces_fops);
if (!entry)
- pr_warning("Could not create debugfs 'trace' entry\n");
+ pr_warning("Could not create debugfs 'available_tracers' entry\n");
entry = debugfs_create_file("current_tracer", 0444, d_tracer,
&global_trace, &set_tracer_fops);
if (!entry)
- pr_warning("Could not create debugfs 'trace' entry\n");
+ pr_warning("Could not create debugfs 'current_tracer' entry\n");
entry = debugfs_create_file("tracing_max_latency", 0644, d_tracer,
&tracing_max_latency,
@@ -2899,7 +2899,7 @@ static __init void tracer_init_debugfs(v
&tracing_thresh, &tracing_max_lat_fops);
if (!entry)
pr_warning("Could not create debugfs "
- "'tracing_threash' entry\n");
+ "'tracing_thresh' entry\n");
entry = debugfs_create_file("README", 0644, d_tracer,
NULL, &tracing_readme_fops);
if (!entry)
@@ -2909,13 +2909,13 @@ static __init void tracer_init_debugfs(v
NULL, &tracing_pipe_fops);
if (!entry)
pr_warning("Could not create debugfs "
- "'tracing_threash' entry\n");
+ "'trace_pipe' entry\n");
entry = debugfs_create_file("trace_entries", 0644, d_tracer,
&global_trace, &tracing_entries_fops);
if (!entry)
pr_warning("Could not create debugfs "
- "'tracing_threash' entry\n");
+ "'trace_entries' entry\n");
#ifdef CONFIG_DYNAMIC_FTRACE
entry = debugfs_create_file("dyn_ftrace_total_info", 0444, d_tracer,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] trace: Fix some mistakes in error messages
2008-08-11 22:06 Frédéric Weisbecker
@ 2008-08-14 13:13 ` Frédéric Weisbecker
0 siblings, 0 replies; 6+ messages in thread
From: Frédéric Weisbecker @ 2008-08-14 13:13 UTC (permalink / raw)
To: mingo, srostedt; +Cc: Linux Kernel
2008/8/11 Frédéric Weisbecker <fweisbec@gmail.com>
>
> This patch fixes some mistakes on the tracer in warning messages when debugfs fails to create tracing files.
> Kernel version: 2.6.27-rc1
>
> Regards.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> diff -rup a/kernel/trace/trace.c b/kernel/trace/trace.c
> --- a/kernel/trace/trace.c 2008-08-11 22:44:25.000000000 +0200
> +++ b/kernel/trace/trace.c 2008-08-11 23:10:39.000000000 +0200
> @@ -2881,12 +2881,12 @@ static __init void tracer_init_debugfs(v
> entry = debugfs_create_file("available_tracers", 0444, d_tracer,
> &global_trace, &show_traces_fops);
> if (!entry)
> - pr_warning("Could not create debugfs 'trace' entry\n");
> + pr_warning("Could not create debugfs 'available_tracers' entry\n");
>
> entry = debugfs_create_file("current_tracer", 0444, d_tracer,
> &global_trace, &set_tracer_fops);
> if (!entry)
> - pr_warning("Could not create debugfs 'trace' entry\n");
> + pr_warning("Could not create debugfs 'current_tracer' entry\n");
>
> entry = debugfs_create_file("tracing_max_latency", 0644, d_tracer,
> &tracing_max_latency,
> @@ -2899,7 +2899,7 @@ static __init void tracer_init_debugfs(v
> &tracing_thresh, &tracing_max_lat_fops);
> if (!entry)
> pr_warning("Could not create debugfs "
> - "'tracing_threash' entry\n");
> + "'tracing_thresh' entry\n");
> entry = debugfs_create_file("README", 0644, d_tracer,
> NULL, &tracing_readme_fops);
> if (!entry)
> @@ -2909,13 +2909,13 @@ static __init void tracer_init_debugfs(v
> NULL, &tracing_pipe_fops);
> if (!entry)
> pr_warning("Could not create debugfs "
> - "'tracing_threash' entry\n");
> + "'trace_pipe' entry\n");
>
> entry = debugfs_create_file("trace_entries", 0644, d_tracer,
> &global_trace, &tracing_entries_fops);
> if (!entry)
> pr_warning("Could not create debugfs "
> - "'tracing_threash' entry\n");
> + "'trace_entries' entry\n");
>
> #ifdef CONFIG_DYNAMIC_FTRACE
> entry = debugfs_create_file("dyn_ftrace_total_info", 0444, d_tracer,
I said my kernel version was 2.6.27-rc1 but in fact it still applies
on last git tree.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] trace: Fix some mistakes in error messages
2008-08-11 22:07 [PATCH] trace: Fix some mistakes in error messages Frédéric Weisbecker
@ 2008-08-15 12:59 ` Ingo Molnar
2008-08-15 19:08 ` Frédéric Weisbecker
0 siblings, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2008-08-15 12:59 UTC (permalink / raw)
To: Frédéric Weisbecker; +Cc: mingo, srostedt, Linux Kernel
* Frédéric Weisbecker <fweisbec@gmail.com> wrote:
> This patch fixes some mistakes on the tracer in warning messages when
> debugfs fails to create tracing files. Kernel version: 2.6.27-rc1
hm, the patch is nice, but it is whitespace damaged. Please resend along
the lines of Documentation/email-clients.txt, or as an attachment.
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] trace: Fix some mistakes in error messages
2008-08-15 12:59 ` Ingo Molnar
@ 2008-08-15 19:08 ` Frédéric Weisbecker
2008-08-15 19:54 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Frédéric Weisbecker @ 2008-08-15 19:08 UTC (permalink / raw)
To: Ingo Molnar; +Cc: mingo, srostedt, Linux Kernel
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
Ingo Molnar a écrit :
> * Frédéric Weisbecker <fweisbec@gmail.com> wrote:
>
>> This patch fixes some mistakes on the tracer in warning messages when
>> debugfs fails to create tracing files. Kernel version: 2.6.27-rc1
>
> hm, the patch is nice, but it is whitespace damaged. Please resend along
> the lines of Documentation/email-clients.txt, or as an attachment.
>
> Ingo
Sorry. Now it should be correct.
Pach V2
-------
This patch fixes some mistakes on the tracer in warning messages when
debugfs fails to create tracing files.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
[-- Attachment #2: resend_debugfs_warns.diff --]
[-- Type: text/x-patch, Size: 1745 bytes --]
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 8f3fb3d..943f278 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2881,12 +2881,12 @@ static __init void tracer_init_debugfs(void)
entry = debugfs_create_file("available_tracers", 0444, d_tracer,
&global_trace, &show_traces_fops);
if (!entry)
- pr_warning("Could not create debugfs 'trace' entry\n");
+ pr_warning("Could not create debugfs 'available_tracers' entry\n");
entry = debugfs_create_file("current_tracer", 0444, d_tracer,
&global_trace, &set_tracer_fops);
if (!entry)
- pr_warning("Could not create debugfs 'trace' entry\n");
+ pr_warning("Could not create debugfs 'current_tracer' entry\n");
entry = debugfs_create_file("tracing_max_latency", 0644, d_tracer,
&tracing_max_latency,
@@ -2899,7 +2899,7 @@ static __init void tracer_init_debugfs(void)
&tracing_thresh, &tracing_max_lat_fops);
if (!entry)
pr_warning("Could not create debugfs "
- "'tracing_threash' entry\n");
+ "'tracing_thresh' entry\n");
entry = debugfs_create_file("README", 0644, d_tracer,
NULL, &tracing_readme_fops);
if (!entry)
@@ -2909,13 +2909,13 @@ static __init void tracer_init_debugfs(void)
NULL, &tracing_pipe_fops);
if (!entry)
pr_warning("Could not create debugfs "
- "'tracing_threash' entry\n");
+ "'trace_pipe' entry\n");
entry = debugfs_create_file("trace_entries", 0644, d_tracer,
&global_trace, &tracing_entries_fops);
if (!entry)
pr_warning("Could not create debugfs "
- "'tracing_threash' entry\n");
+ "'trace_entries' entry\n");
#ifdef CONFIG_DYNAMIC_FTRACE
entry = debugfs_create_file("dyn_ftrace_total_info", 0444, d_tracer,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] trace: Fix some mistakes in error messages
2008-08-15 19:08 ` Frédéric Weisbecker
@ 2008-08-15 19:54 ` Ingo Molnar
0 siblings, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2008-08-15 19:54 UTC (permalink / raw)
To: Frédéric Weisbecker; +Cc: mingo, srostedt, Linux Kernel
* Frédéric Weisbecker <fweisbec@gmail.com> wrote:
> Ingo Molnar a écrit :
> > * Frédéric Weisbecker <fweisbec@gmail.com> wrote:
> >
> >> This patch fixes some mistakes on the tracer in warning messages when
> >> debugfs fails to create tracing files. Kernel version: 2.6.27-rc1
> >
> > hm, the patch is nice, but it is whitespace damaged. Please resend along
> > the lines of Documentation/email-clients.txt, or as an attachment.
> >
> > Ingo
>
>
> Sorry. Now it should be correct.
>
> Pach V2
> -------
>
> This patch fixes some mistakes on the tracer in warning messages when
> debugfs fails to create tracing files.
applied to tip/tracing/ftrace - thanks Frédéric!
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-08-15 19:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-11 22:07 [PATCH] trace: Fix some mistakes in error messages Frédéric Weisbecker
2008-08-15 12:59 ` Ingo Molnar
2008-08-15 19:08 ` Frédéric Weisbecker
2008-08-15 19:54 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2008-08-11 22:06 Frédéric Weisbecker
2008-08-14 13:13 ` Frédéric Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox