* [PATCH 2/3][reiser4] don't leave loop prematurely
@ 2008-08-11 22:38 Ryan Hope
2008-08-12 12:54 ` Edward Shishkin
0 siblings, 1 reply; 2+ messages in thread
From: Ryan Hope @ 2008-08-11 22:38 UTC (permalink / raw)
To: LKML, Reiserfs mailing list, Andrew Morton, Edward Shishkin
This was item #9 on the todo list for reiser4 inclusion in mainline:
diff --git a/52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c
b/7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c
index
edf0911dc8bb61398374ecf4f849aa30753fb274..fe713681b73d2a6c4214f5938f21794573d8607d
100644
--- a/52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c
+++ b/7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c
@@ -658,8 +658,7 @@ truncate_jnodes_range(struct inode *inode, pgoff_t from,
pgoff_t count)
unhash_unformatted_jnode(node);
truncated_jnodes++;
jput(node);
- } else
- break;
+ }
}
if (i != taken || taken == 0)
break;
-Ryan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3][reiser4] don't leave loop prematurely
2008-08-11 22:38 [PATCH 2/3][reiser4] don't leave loop prematurely Ryan Hope
@ 2008-08-12 12:54 ` Edward Shishkin
0 siblings, 0 replies; 2+ messages in thread
From: Edward Shishkin @ 2008-08-12 12:54 UTC (permalink / raw)
To: Ryan Hope; +Cc: LKML, Reiserfs mailing list, Andrew Morton
Ryan Hope wrote:
> This was item #9 on the todo list for reiser4 inclusion in mainline:
>
> diff --git
> a/52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c
> b/7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c
> index
> edf0911dc8bb61398374ecf4f849aa30753fb274..fe713681b73d2a6c4214f5938f21794573d8607d
> 100644
> --- a/52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c
> +++ b/7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c
> @@ -658,8 +658,7 @@ truncate_jnodes_range(struct inode *inode, pgoff_t
> from, pgoff_t count)
> unhash_unformatted_jnode(node);
> truncated_jnodes++;
> jput(node);
> - } else
> - break;
> + }
No, this is wrong:
if (node == NULL), then there is nothing to do in this loop.
Edward.
> }
> if (i != taken || taken == 0)
> break;
>
>
> -Ryan
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-12 12:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-11 22:38 [PATCH 2/3][reiser4] don't leave loop prematurely Ryan Hope
2008-08-12 12:54 ` Edward Shishkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox