From: Rene Herman <rene.herman@keyaccess.nl>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] PNP: make the resource type an unsigned long
Date: Tue, 12 Aug 2008 06:15:13 +0200 [thread overview]
Message-ID: <48A10E51.6030505@keyaccess.nl> (raw)
In-Reply-To: <200808111559.01575.bjorn.helgaas@hp.com>
On 11-08-08 23:59, Bjorn Helgaas wrote:
> On Friday 08 August 2008 12:39:45 am Rene Herman wrote:
>> Andrew earlier commented that pci_resourec_flags() returns an unsigned
>> long. Had this hanging around a local branch. Useful?
>
> I see hpa's point that it makes no functional difference, but I do
> think it's worthwhile to make the types match. I don't want to
> debug the problem that happens when somebody adds an IORESOURCE_*
> flag in the upper bits.
>
> You probably want to send this (and the next one, which is really
> a pci_resource_flags() usage despite being in drivers/pnp/quirks.c)
> to Andi Kleen.
>
> Acked-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Okay, thanks. I see that Andrew picked these up with Andi in CC so I'll
assume things will find their way from there.
Rene.
prev parent reply other threads:[~2008-08-12 4:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 6:39 [PATCH] PNP: make the resource type an unsigned long Rene Herman
2008-08-08 21:55 ` H. Peter Anvin
2008-08-09 5:21 ` Rene Herman
2008-08-09 5:25 ` H. Peter Anvin
2008-08-09 5:32 ` Rene Herman
2008-08-11 21:59 ` Bjorn Helgaas
2008-08-11 22:08 ` H. Peter Anvin
2008-08-11 22:18 ` Bjorn Helgaas
2008-08-12 4:15 ` Rene Herman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A10E51.6030505@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox