From: Avi Kivity <avi@qumranet.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@argo.co.il>, kvm-devel <kvm@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] reduce kvm stack usage in kvm_arch_vm_ioctl()
Date: Tue, 12 Aug 2008 16:00:08 +0300 [thread overview]
Message-ID: <48A18958.8060307@qumranet.com> (raw)
In-Reply-To: <1218474105-14678-1-git-send-email-dave@linux.vnet.ibm.com>
Dave Hansen wrote:
> On my machine with gcc 3.4, kvm uses ~2k of stack in a few
> select functions. This is mostly because gcc fails to
> notice that the different case: statements could have their
> stack usage combined. It overflows very nicely if interrupts
> happen during one of these large uses.
>
> This patch uses two methods for reducing stack usage.
> 1. dynamically allocate large objects instead of putting
> on the stack.
> 2. Use a union{} member for all of the case variables. This
> tricks gcc into combining them all into a single stack
> allocation. (There's also a comment on this)
>
>
Applied all, thanks.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-08-12 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 17:01 [PATCH 1/4] reduce kvm stack usage in kvm_arch_vm_ioctl() Dave Hansen
2008-08-11 17:01 ` [PATCH 2/4] reduce stack usage in kvm_vcpu_ioctl() Dave Hansen
2008-08-11 17:01 ` [PATCH 3/4] reduce stack usage in kvm_arch_vcpu_ioctl() Dave Hansen
2008-08-11 17:01 ` [PATCH 4/4] kvm: reduce stack usage in kvm_pv_mmu_op() Dave Hansen
2008-08-12 13:00 ` Avi Kivity [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-08-04 18:31 [PATCH 1/4] reduce kvm stack usage in kvm_arch_vm_ioctl() Dave Hansen
2008-08-11 9:29 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A18958.8060307@qumranet.com \
--to=avi@qumranet.com \
--cc=avi@argo.co.il \
--cc=dave@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox