public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mark Langsdorf <mark.langsdorf@amd.com>,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: invalidate caches before going into suspend
Date: Wed, 13 Aug 2008 10:28:11 -0700	[thread overview]
Message-ID: <48A319AB.9030707@zytor.com> (raw)
In-Reply-To: <20080813170133.GA16557@elte.hu>

Ingo Molnar wrote:
>>>
>> Spurious interrupt of what kind?  The only things that could come in 
>> would not be non-INT type interrupts, and those aren't affected by 
>> CLI.
> 
> nothing should come in really at that point - but say IRQ#7 on older 
> platforms used to trigger at various points in time, even unprompted. Or 
> an APIC error interrupt in the last moment? All device irqs should 
> indeed be turned off at this stage, but since it costs us nothing to add 
> another cli, and because the failure mode is subtle memory corruption, 
> does it hurt to have it?
> 

Not significantly, but I cannot for my life figure out how it could help.

Either the interrupts will be blocked by the CLI already in effect, or 
the additional CLI will not help, either (in fact, it will just slightly 
increase the window for something like that to slip in.)

	-hpa


  reply	other threads:[~2008-08-13 17:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 16:41 invalidate caches before going into suspend Mark Langsdorf
2008-08-13 16:47 ` Ingo Molnar
2008-08-13 16:53   ` H. Peter Anvin
2008-08-13 17:01     ` Ingo Molnar
2008-08-13 17:28       ` H. Peter Anvin [this message]
2008-08-13 17:35         ` Ingo Molnar
2008-08-13 17:37           ` H. Peter Anvin
2008-08-13 17:09   ` Mark Langsdorf
2008-08-13 17:17     ` Linus Torvalds
2008-08-13 17:30       ` Mark Langsdorf
2008-08-13 17:52         ` Ingo Molnar
2008-08-13 18:33           ` [PATCH](retry 2) " Mark Langsdorf
2008-08-13 18:42             ` Arjan van de Ven
2008-08-13 18:47               ` Langsdorf, Mark
2008-08-13 21:32                 ` Arjan van de Ven
2008-08-14 13:45                   ` [PATCH](retry 3) " Mark Langsdorf
2008-08-14 13:49                     ` Ingo Molnar
2008-08-14 14:00                     ` Arjan van de Ven
2008-08-14 14:11                     ` [PATCH](retry 4) " Mark Langsdorf
2008-08-15 12:04                       ` Ingo Molnar
2008-08-13 17:38     ` Ingo Molnar
2008-08-13 19:39 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A319AB.9030707@zytor.com \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.langsdorf@amd.com \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox