From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Ian Campbell <ijc@hellion.org.uk>,
linux-kernel@vger.kernel.org, Kel Modderman <kel@otaku42.de>,
Markus Armbruster <armbru@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: kernel BUG at lib/radix-tree.c:473!
Date: Thu, 14 Aug 2008 15:04:49 -0700 [thread overview]
Message-ID: <48A4AC01.7040402@goop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0808142104080.29719@blonde.site>
Hugh Dickins wrote:
> As you can see, I'm still groping towards the right answer.
> The driver probably needs to provide its own backing_dev_info
> (or point to a suitable default), and its own address_space_ops,
> and perhaps more (there should be examples elsewhere). But whether
> it is actually wrong, or whether I was wrong to mess it up, I've
> not yet decided.
>
My understanding is that the driver is doing something a bit clever: it
uses the page dirty flags to determine which parts of the framebuffer
have been written to, and uses that information to minimize the amount
of stuff that needs to be copied out. The writes to the pages are not
expected to generate actual page faults.
But I haven't really looked at it closely, and I'm not at all familiar
with the vm at this layer. I'm not sure how it actually allocates the
framebuffer memory for example (vmalloc? incrementally on faults?).
I'm hoping Markus will leap in, since wrote this stuff. Or, gasp, I'll
read the code myself.
> An additional useful input would be: what happens if you replace
> that /dev/fb0 by a symlink /dev/fb0 pointing to an fb0 device node in
> one of your disk filesystems? I rather expect that to cause the same
> trouble, which would argue that the driver is wrong and shmem right.
>
I don't follow. Do you mean make /dev/fb0 a plain file on a filesystem?
Or make it a disk device node? Something else?
J
next prev parent reply other threads:[~2008-08-14 22:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 7:02 kernel BUG at lib/radix-tree.c:473! Ian Campbell
2008-08-14 10:41 ` Peter Zijlstra
2008-08-14 13:06 ` Hugh Dickins
2008-08-14 14:56 ` Ian Campbell
2008-08-14 17:42 ` Hugh Dickins
2008-08-14 17:38 ` Jeremy Fitzhardinge
2008-08-14 19:33 ` Jeremy Fitzhardinge
2008-08-14 21:03 ` Hugh Dickins
2008-08-14 22:04 ` Jeremy Fitzhardinge [this message]
2008-08-14 22:48 ` Markus Armbruster
2008-08-17 12:09 ` Jaya Kumar
2008-08-17 14:00 ` zhang wenjie
2008-08-14 23:13 ` Johannes Weiner
2008-08-15 0:00 ` Hugh Dickins
2008-08-17 16:19 ` Ian Campbell
2008-08-18 1:32 ` Nick Piggin
2008-08-18 7:54 ` Ian Campbell
2008-08-18 8:04 ` Peter Zijlstra
2008-08-18 8:05 ` Nick Piggin
2008-08-18 8:22 ` Jaya Kumar
-- strict thread matches above, loose matches on Subject: below --
2008-08-17 3:37 zhang wenjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A4AC01.7040402@goop.org \
--to=jeremy@goop.org \
--cc=a.p.zijlstra@chello.nl \
--cc=armbru@redhat.com \
--cc=hugh@veritas.com \
--cc=ijc@hellion.org.uk \
--cc=kel@otaku42.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox