Re: [PATCH] trace: Fix some mistakes in error messages

["Frédéric Weisbecker" <fweisbec@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Ingo Molnar a écrit :
> * Frédéric Weisbecker <fweisbec@gmail.com> wrote:
> 
>> This patch fixes some mistakes on the tracer in warning messages when 
>> debugfs fails to create tracing files. Kernel version: 2.6.27-rc1
> 
> hm, the patch is nice, but it is whitespace damaged. Please resend along 
> the lines of Documentation/email-clients.txt, or as an attachment.
> 
> 	Ingo


Sorry. Now it should be correct.

Pach V2
-------

This patch fixes some mistakes on the tracer in warning messages when 
debugfs fails to create tracing files.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---


[-- Attachment #2: resend_debugfs_warns.diff --]
[-- Type: text/x-patch, Size: 1745 bytes --]

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 8f3fb3d..943f278 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2881,12 +2881,12 @@ static __init void tracer_init_debugfs(void)
 	entry = debugfs_create_file("available_tracers", 0444, d_tracer,
 				    &global_trace, &show_traces_fops);
 	if (!entry)
-		pr_warning("Could not create debugfs 'trace' entry\n");
+		pr_warning("Could not create debugfs 'available_tracers' entry\n");
 
 	entry = debugfs_create_file("current_tracer", 0444, d_tracer,
 				    &global_trace, &set_tracer_fops);
 	if (!entry)
-		pr_warning("Could not create debugfs 'trace' entry\n");
+		pr_warning("Could not create debugfs 'current_tracer' entry\n");
 
 	entry = debugfs_create_file("tracing_max_latency", 0644, d_tracer,
 				    &tracing_max_latency,
@@ -2899,7 +2899,7 @@ static __init void tracer_init_debugfs(void)
 				    &tracing_thresh, &tracing_max_lat_fops);
 	if (!entry)
 		pr_warning("Could not create debugfs "
-			   "'tracing_threash' entry\n");
+			   "'tracing_thresh' entry\n");
 	entry = debugfs_create_file("README", 0644, d_tracer,
 				    NULL, &tracing_readme_fops);
 	if (!entry)
@@ -2909,13 +2909,13 @@ static __init void tracer_init_debugfs(void)
 				    NULL, &tracing_pipe_fops);
 	if (!entry)
 		pr_warning("Could not create debugfs "
-			   "'tracing_threash' entry\n");
+			   "'trace_pipe' entry\n");
 
 	entry = debugfs_create_file("trace_entries", 0644, d_tracer,
 				    &global_trace, &tracing_entries_fops);
 	if (!entry)
 		pr_warning("Could not create debugfs "
-			   "'tracing_threash' entry\n");
+			   "'trace_entries' entry\n");
 
 #ifdef CONFIG_DYNAMIC_FTRACE
 	entry = debugfs_create_file("dyn_ftrace_total_info", 0444, d_tracer,