From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Harvey Harrison <harvey.harrison@gmail.com>,
Andi Kleen <andi@firstfloor.org>,
Steven Rostedt <rostedt@goodmis.org>,
Steven Rostedt <srostedt@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Roland McGrath <roland@redhat.com>,
Ulrich Drepper <drepper@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Gregory Haskins <ghaskins@novell.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"Luis Claudio R. Goncalves" <lclaudio@uudg.org>,
Clark Williams <williams@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH] x86 : spinlock use LOCK_PREFIX
Date: Fri, 15 Aug 2008 13:27:10 -0700 [thread overview]
Message-ID: <48A5E69E.7060003@zytor.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0808151031310.3324@nehalem.linux-foundation.org>
Linus Torvalds wrote:
>
> On Fri, 15 Aug 2008, Mathieu Desnoyers wrote:
>> Unless there a rationale for this, I think these be changed to LOCK_PREFIX
>> too.
>>
>> grep "lock ;" include/asm-x86/spinlock.h
>> "lock ; cmpxchgw %w1,%2\n\t"
>> asm volatile("lock ; xaddl %0, %1\n"
>> "lock ; cmpxchgl %1,%2\n\t"
>
> Ack.
>
Full patch series applied to tip:x86/alternatives; we'll migrate it to
tip:x86/urgent for upstream delivery after some testing.
-hpa
prev parent reply other threads:[~2008-08-15 20:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 20:58 [PATCH] x86 alternatives : fix LOCK_PREFIX race with preemptible kernel and CPU hotplug Mathieu Desnoyers
2008-08-14 21:20 ` Andi Kleen
2008-08-14 21:43 ` H. Peter Anvin
2008-08-15 16:06 ` Linus Torvalds
2008-08-15 16:45 ` [PATCH] x86 : revert replace LOCK_PREFIX in futex.h Mathieu Desnoyers
2008-08-15 16:56 ` [PATCH] x86 : spinlock use LOCK_PREFIX Mathieu Desnoyers
2008-08-15 17:31 ` Linus Torvalds
2008-08-15 20:27 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A5E69E.7060003@zytor.com \
--to=hpa@zytor.com \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=drepper@redhat.com \
--cc=ghaskins@novell.com \
--cc=harvey.harrison@gmail.com \
--cc=jeremy@goop.org \
--cc=lclaudio@uudg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox