From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Roland McGrath <roland@redhat.com>,
Ulrich Drepper <drepper@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Gregory Haskins <ghaskins@novell.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"Luis Claudio R. Goncalves" <lclaudio@uudg.org>,
Clark Williams <williams@redhat.com>,
srostedt@redhat.com
Subject: Re: [PATCH] ftrace: use only 5 byte nops for x86
Date: Fri, 15 Aug 2008 15:30:19 -0700 [thread overview]
Message-ID: <48A6037B.6030202@zytor.com> (raw)
In-Reply-To: <20080815092231.GB22209@elte.hu>
Ingo Molnar wrote:
>>>
>>> TODO: Examine the cpuid to determine the nop to use.
>>>
>> Don't think that will help in general. qemu claims its a Pentium II.
>
> ok. I've applied Steve's patch as it's a good bugfix. The extra paranoia
> about faulting on 0x90 seems excessive but doesnt hurt ;-)
>
I think what we need to do is to test the NOPL instruction and create a
Linux-specific CPUID bit for it. I'll do that and submit to tip:x86/cpu.
-hpa
next prev parent reply other threads:[~2008-08-15 22:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 22:05 [PATCH] ftrace: use only 5 byte nops for x86 Steven Rostedt
2008-08-14 23:49 ` Jeremy Fitzhardinge
2008-08-15 9:22 ` Ingo Molnar
2008-08-15 22:30 ` H. Peter Anvin [this message]
2008-08-15 22:44 ` Linus Torvalds
2008-08-15 22:50 ` Jeremy Fitzhardinge
2008-08-15 22:52 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A6037B.6030202@zytor.com \
--to=hpa@zytor.com \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=drepper@redhat.com \
--cc=ghaskins@novell.com \
--cc=jeremy@goop.org \
--cc=lclaudio@uudg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox