From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Roland McGrath <roland@redhat.com>,
Ulrich Drepper <drepper@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Gregory Haskins <ghaskins@novell.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"Luis Claudio R. Goncalves" <lclaudio@uudg.org>,
Clark Williams <williams@redhat.com>,
srostedt@redhat.com
Subject: Re: [PATCH] ftrace: use only 5 byte nops for x86
Date: Fri, 15 Aug 2008 15:50:22 -0700 [thread overview]
Message-ID: <48A6082E.70405@goop.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0808151542330.3324@nehalem.linux-foundation.org>
Linus Torvalds wrote:
> I also suspect that we'd really be much better off just fixing the generic
> NOP tables for the 5-byte nop. As far as I could tell, from all the
> numbers that have been posted, absolutely _none_ show that there is any
> point at all to the 2-instruction 3/2-byte sequence.
>
> So instead of having a magic special ftrace-only thing, why not just do it
> right, and fix the generic 5-byte nop sequence?
>
Well, there's two distinct issues here. There's the need for a
single-instruction 5 byte nop, and the need for efficient nops. It so
happens in this case that they're the same thing. But in general, the
generic nop interface is intended to return the most efficient nop, not
an atomic nop (or with any other properties). To handle it generically,
we'd either need to redefine the meaning of the existing nop-padding
interface, or add an "atomic nop" interface.
J
next prev parent reply other threads:[~2008-08-15 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 22:05 [PATCH] ftrace: use only 5 byte nops for x86 Steven Rostedt
2008-08-14 23:49 ` Jeremy Fitzhardinge
2008-08-15 9:22 ` Ingo Molnar
2008-08-15 22:30 ` H. Peter Anvin
2008-08-15 22:44 ` Linus Torvalds
2008-08-15 22:50 ` Jeremy Fitzhardinge [this message]
2008-08-15 22:52 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A6082E.70405@goop.org \
--to=jeremy@goop.org \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=drepper@redhat.com \
--cc=ghaskins@novell.com \
--cc=hpa@zytor.com \
--cc=lclaudio@uudg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox