* [PATCH] audit: Moved variable declaration to beginning of function
@ 2008-08-18 16:45 Cordelia
2008-08-18 22:23 ` James Morris
0 siblings, 1 reply; 2+ messages in thread
From: Cordelia @ 2008-08-18 16:45 UTC (permalink / raw)
To: linux-kernel
got rid of compilation warning:
ISO C90 forbids mixed declarations and code
Signed-off-by: Cordelia Sam <cordesam@gmail.com>
---
kernel/auditsc.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 972f8e6..59cedfb 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -243,10 +243,11 @@ static inline int open_arg(int flags, int mask)
static int audit_match_perm(struct audit_context *ctx, int mask)
{
+ unsigned n;
if (unlikely(!ctx))
return 0;
- unsigned n = ctx->major;
+ n = ctx->major;
switch (audit_classify_syscall(ctx->arch, n)) {
case 0: /* native */
if ((mask & AUDIT_PERM_WRITE) &&
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] audit: Moved variable declaration to beginning of function
2008-08-18 16:45 [PATCH] audit: Moved variable declaration to beginning of function Cordelia
@ 2008-08-18 22:23 ` James Morris
0 siblings, 0 replies; 2+ messages in thread
From: James Morris @ 2008-08-18 22:23 UTC (permalink / raw)
To: Cordelia; +Cc: linux-kernel, Al Viro
On Mon, 18 Aug 2008, Cordelia wrote:
> got rid of compilation warning:
> ISO C90 forbids mixed declarations and code
>
> Signed-off-by: Cordelia Sam <cordesam@gmail.com>
> ---
> kernel/auditsc.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 972f8e6..59cedfb 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -243,10 +243,11 @@ static inline int open_arg(int flags, int mask)
>
> static int audit_match_perm(struct audit_context *ctx, int mask)
> {
> + unsigned n;
> if (unlikely(!ctx))
> return 0;
>
> - unsigned n = ctx->major;
> + n = ctx->major;
> switch (audit_classify_syscall(ctx->arch, n)) {
> case 0: /* native */
> if ((mask & AUDIT_PERM_WRITE) &&
Reviewed-by: James Morris <jmorris@namei.org>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-18 22:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-18 16:45 [PATCH] audit: Moved variable declaration to beginning of function Cordelia
2008-08-18 22:23 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox