[PATCH] KVM x86_emulate.c: duplicate SrcImm

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] KVM x86_emulate.c: duplicate SrcImm
@ 2008-08-19  1:25 roel kluin
  2008-08-21 14:38 ` Avi Kivity
  0 siblings, 1 reply; 2+ messages in thread
From: roel kluin @ 2008-08-19  1:25 UTC (permalink / raw)
  To: avi, linux-kernel

Hi avi,

you added this in commit 7d858a19efe5844a98e060931570359b70dea6d1
any idea whether it should be replaced by something else?
---
duplicate SrcImm

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index f2f9046..78b76c9 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -268,7 +268,7 @@ static u16 group_table[] = {
 	ByteOp | DstMem | SrcNone | ModRM, ByteOp | DstMem | SrcNone | ModRM,
 	0, 0, 0, 0,
 	[Group3*8] =
-	DstMem | SrcImm | ModRM | SrcImm, 0,
+	DstMem | SrcImm | ModRM, 0,
 	DstMem | SrcNone | ModRM, ByteOp | DstMem | SrcNone | ModRM,
 	0, 0, 0, 0,
 	[Group4*8] =

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] KVM x86_emulate.c: duplicate SrcImm
  2008-08-19  1:25 [PATCH] KVM x86_emulate.c: duplicate SrcImm roel kluin
@ 2008-08-21 14:38 ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-08-21 14:38 UTC (permalink / raw)
  To: roel kluin; +Cc: linux-kernel

roel kluin wrote:
> Hi avi,
>
> you added this in commit 7d858a19efe5844a98e060931570359b70dea6d1
> any idea whether it should be replaced by something else?
> ---
> duplicate SrcImm
>   

Right.  Applied.

I don't know if some other bit is missing a SrcImm.  I'll review that code.


-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-21 14:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-19  1:25 [PATCH] KVM x86_emulate.c: duplicate SrcImm roel kluin
2008-08-21 14:38 ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox