public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Justin Madru <jdm64@gawab.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Michal Januszewski <spock@gentoo.org>,
	Antonino Daplas <adaplas@gmail.com>, Greg KH <gregkh@suse.de>,
	Rafael Wysocki <rjw@sisk.pl>,
	Romano Giannetti <romano.giannetti@gmail.com>,
	Adrian Bunk <bunk@kernel.org>,
	Jeremy Nickurak <kernel-bugs@atrus.rifetech.com>
Subject: Re: Backport hr-tick fix into .25/.26
Date: Mon, 18 Aug 2008 19:43:53 -0700	[thread overview]
Message-ID: <48AA3369.900@gawab.com> (raw)
In-Reply-To: <20080819003110.GH9914@elte.hu>

Ingo Molnar wrote:
> hm, the backport of 31656519 is a bit intrusive.
>
> find below is an (untested!) version of it - i havent even build-tested 
> it. Does it work for you? But this is Greg's call really.
>   

I tried to apply it onto 2.6.26.2, but got this build error:

CC arch/x86/kernel/i8253.o
CC kernel/sched.o
CC arch/x86/kernel/pci-nommu.o
kernel/sched.c:537: error: field ‘hrtick_csd’ has incomplete type
kernel/sched.c: In function ‘hrtick_start’:
kernel/sched.c:1080: error: implicit declaration of function 
‘__smp_call_function_single’
CC arch/x86/kernel/tsc_32.o
make[2]: *** [kernel/sched.o] Error 1
make[1]: *** [kernel] Error 2
make[1]: *** Waiting for unfinished jobs....
CC arch/x86/kernel/io_delay.o
CC arch/x86/kernel/rtc.o
CC arch/x86/kernel/trampoline.o

Was I suppose to use a different kernel? (2.6.25[.x] or 2.6.26) I'll try 
2.6.25.15

Anyways, I know it's Greg's call, and I'm just trying to inform him of a 
bug that's been fixed upstream that should be backported.
If he declines, that's ok. I've opened a bug report with Ubuntu. But, it 
would help if I had a patch to show.

Justin Madru

  reply	other threads:[~2008-08-19  2:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-18 18:21 Backport hr-tick fix into .25/.26 Justin Madru
2008-08-19  0:31 ` Ingo Molnar
2008-08-19  2:43   ` Justin Madru [this message]
2008-08-19  6:28   ` Peter Zijlstra
2008-08-19  9:25     ` Ingo Molnar
2008-08-19  9:33       ` Peter Zijlstra
2008-08-19 18:22         ` Greg KH
2008-08-19 19:30           ` Justin Madru
2008-08-19 19:44             ` Greg KH
2008-08-19 22:54               ` [PATCH] sched: disable hrtick implementation Justin Madru
2008-08-20  7:24                 ` Peter Zijlstra
2008-08-20 18:43                   ` Justin Madru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48AA3369.900@gawab.com \
    --to=jdm64@gawab.com \
    --cc=adaplas@gmail.com \
    --cc=bunk@kernel.org \
    --cc=gregkh@suse.de \
    --cc=kernel-bugs@atrus.rifetech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rjw@sisk.pl \
    --cc=romano.giannetti@gmail.com \
    --cc=spock@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox