public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@csr.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kernel development list <linux-kernel@vger.kernel.org>,
	e1000-devel@lists.sourceforge.net, jeffrey.t.kirsher@intel.com,
	"Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Subject: Re: e1000e: 2.6.27-rc1 corrupts EEPROM/NVM
Date: Tue, 19 Aug 2008 10:50:15 +0100	[thread overview]
Message-ID: <48AA9757.3090002@csr.com> (raw)
In-Reply-To: <20080818224011.6fad74dc.akpm@linux-foundation.org>

Andrew Morton wrote:
> On Fri, 08 Aug 2008 11:47:51 +0100 David Vrabel <david.vrabel@csr.com> wrote:
> 
>> 2.6.27-rc1 kernels appear to corrupt the EEPROM/NVM of the 8086:294c
>> ethernet device (ICH9 I think).  After hacking the driver to ignore the
>> bad CRC and MAC address I could view the EEPROM with ethtool and it was
>> all 0xff.
>>
>> Testing EEPROM reads and writes with ethtool appeared to work but after
>> a reboot of the system the ethernet device (see lspci -v output) was no
>> longer present.  Could invalid EEPROM contents with a valid CRC (as
>> would be the case after my read/write tests) result in the device
>> failing to enumerate on the PCIe bus?

FYI, Jesse Brandeburg replied off-list and said that a corrupt EEPROM
with a valid CRC can result in the device failing to enumerate.

> Is this still happening in Linus's current tree?

I don't know, and I'm reluctant to try until I have a reliable way to
restore an erased EEPROM.

> Was 2.6.26 OK?

2.6.26 was fine.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/

  reply	other threads:[~2008-08-19  9:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08 10:47 e1000e: 2.6.27-rc1 corrupts EEPROM/NVM David Vrabel
2008-08-19  5:40 ` Andrew Morton
2008-08-19  9:50   ` David Vrabel [this message]
2008-08-19 10:02     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48AA9757.3090002@csr.com \
    --to=david.vrabel@csr.com \
    --cc=akpm@linux-foundation.org \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox