From: Benny Halevy <bhalevy@panasas.com>
To: Linux Audit <linux-audit@redhat.com>
Cc: zhangxiliang <zhangxiliang@cn.fujitsu.com>,
Eric Paris <eparis@redhat.com>, Steve Grubb <sgrubb@redhat.com>,
viro@zeniv.linux.org.uk,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Yu Zhiguo <yuzg@cn.fujitsu.com>
Subject: [PATCH] fix warning in audit_match_perm
Date: Wed, 20 Aug 2008 14:18:09 +0300 [thread overview]
Message-ID: <48ABFD71.6070702@panasas.com> (raw)
In-Reply-To: <4893CCE5.7020907@cn.fujitsu.com>
kernel/auditsc.c: In function ‘audit_match_perm’:
kernel/auditsc.c:249: warning: ISO C90 forbids mixed declarations and code
This was introduced in commit
1a61c88defcd611bd148d6c960b498e1b8bbbe00
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
---
kernel/auditsc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 972f8e6..e72b161 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -243,10 +243,12 @@ static inline int open_arg(int flags, int mask)
static int audit_match_perm(struct audit_context *ctx, int mask)
{
+ unsigned n;
+
if (unlikely(!ctx))
return 0;
- unsigned n = ctx->major;
+ n = ctx->major;
switch (audit_classify_syscall(ctx->arch, n)) {
case 0: /* native */
if ((mask & AUDIT_PERM_WRITE) &&
--
1.6.0
prev parent reply other threads:[~2008-08-20 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 11:15 [PATCH] Fix the kernel panic of audit_filter_task when key field is set zhangxiliang
2008-08-02 2:19 ` zhangxiliang
2008-08-02 2:51 ` Yu Zhiguo
2008-08-02 2:56 ` zhangxiliang
2008-08-04 10:20 ` Al Viro
2008-08-20 11:18 ` Benny Halevy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48ABFD71.6070702@panasas.com \
--to=bhalevy@panasas.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sgrubb@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yuzg@cn.fujitsu.com \
--cc=zhangxiliang@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox