From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jaya Kumar <jayakumar.lkml@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ian Campbell <ijc@hellion.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Nick Piggin <npiggin@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Hugh Dickins <hugh@veritas.com>,
Johannes Weiner <hannes@saeurebad.de>,
Kel Modderman <kel@otaku42.de>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] fbdefio: add set_page_dirty handler to deferred IO FB
Date: Wed, 20 Aug 2008 11:47:34 -0700 [thread overview]
Message-ID: <48AC66C6.1080406@goop.org> (raw)
In-Reply-To: <45a44e480808200146m1167b8e6o74d68324ad138dc5@mail.gmail.com>
Jaya Kumar wrote:
> I hope I have understood your question. You are right that PG_dirty
> isn't used directly in defio. The defio portion does use each
> page_mkwrite callback to build a list of the pages of the framebuffer
> that were written to and then passes that list to pvfb (in this case).
> pvfb then optimizes writeback by interpreting that list according to
> its framebuffer and sending it to its actual destination. I think
> Markus's code in xenfb_deferred_io() and xenfb_send* is doing the
> latter.
>
The original Xen-specific implementation of this did use PG_dirty, which
has the nice property of using the hardware feature without invoking any
pagefaults. It would be nice if defio could be extended to allow this
on platforms where it makes sense.
J
prev parent reply other threads:[~2008-08-20 18:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 6:02 [PATCH] fbdefio: add set_page_dirty handler to deferred IO FB Ian Campbell
2008-08-19 6:38 ` Andrew Morton
2008-08-19 7:13 ` Peter Zijlstra
2008-08-20 8:13 ` Ian Campbell
2008-08-20 8:37 ` Andrew Morton
2008-08-20 18:57 ` Ian Campbell
2008-08-20 19:30 ` Andrew Morton
2008-08-20 19:40 ` Ian Campbell
2008-08-20 19:50 ` Andrew Morton
2008-08-20 23:11 ` Jaya Kumar
2008-08-20 8:46 ` Jaya Kumar
2008-08-20 12:27 ` Markus Armbruster
2008-08-20 18:47 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AC66C6.1080406@goop.org \
--to=jeremy@goop.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=armbru@redhat.com \
--cc=hannes@saeurebad.de \
--cc=hugh@veritas.com \
--cc=ijc@hellion.org.uk \
--cc=jayakumar.lkml@gmail.com \
--cc=kel@otaku42.de \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox