From: Ric Wheeler <rwheeler@redhat.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, Milan Broz <mbroz@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"MASON,CHRISTOPHER" <CHRIS.MASON@oracle.com>
Subject: Re: Mount ext3 with barrier=1 doesn't send real barrier bio?
Date: Thu, 21 Aug 2008 06:43:16 -0400 [thread overview]
Message-ID: <48AD46C4.30207@redhat.com> (raw)
In-Reply-To: <20080821052604.GM20055@kernel.dk>
Jens Axboe wrote:
> On Wed, Aug 20 2008, Eric Sandeen wrote:
>
>> Milan Broz wrote:
>>
>>> Hi,
>>>
>>> I run some barrier tests over device-mapper (which currently doesn't
>>> support barrier bio at all) and even if I set barrier=1 in ext3 mount,
>>> there is never any bio with barrier flag... (in 2.6.27-rc)
>>>
>>> How is the barrier=1 flag supposed to work in ext3 (JBD) now?
>>>
>> Milan, you're right. Ric saw this same strange behavior when doing some
>> benchmarking with and without barriers; Chris noticed the change in
>> submit_bh; I was about to write up a similar patch to what you've sent
>> already. Jens, does Milan's fix look good to you?
>>
>
> Yep looks good, thanks a lot Milan! I'll send in the patch, unless I'm
> badly mistaken we need it for 2.6.26-stable as well.
>
>
I think we definitely need it there as well, thanks!
Ric
next prev parent reply other threads:[~2008-08-21 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 21:31 Mount ext3 with barrier=1 doesn't send real barrier bio? Milan Broz
2008-08-20 23:38 ` Eric Sandeen
2008-08-21 5:26 ` Jens Axboe
2008-08-21 10:43 ` Ric Wheeler [this message]
2008-08-21 22:23 ` OGAWA Hirofumi
2008-08-22 6:38 ` Jens Axboe
2008-08-22 7:45 ` OGAWA Hirofumi
2008-08-22 7:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AD46C4.30207@redhat.com \
--to=rwheeler@redhat.com \
--cc=CHRIS.MASON@oracle.com \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox