Re: [PATCH] sched: properly account IRQ and RT load in SCHED_OTHER load balancing

Ingo Molnar
2008-08-21T11:41:17Z

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Thu, 2008-08-21 at 13:17 +0200, Ingo Molnar wrote:
> > * Ingo Molnar <mingo@elte.hu> wrote:
> >
> > > > This patch tries to solve this issue by accounting the time spend on
> > > > both Real-Time tasks and IRQ handling, and using that to
> > > > proportionally inflate the SCHED_OTHER load.
> > >
> > > applied it to tip/sched/devel for more testing.
> >
> > -tip testing found that it wouldnt build on UP in sched_debug.c - made
> > that bit dependent on CONFIG_SMP. sched_scale_load() does not seem to be
> > too meaningful on UP.
>
> Thanks - just prior to posting I removed the empty stub for
> sched_scale_load() because it didn't make sense for UP code to use
> it...
>
> So much for double checking myself.

hm, the empty stub might be useful still and would remove the #ifdef
from sched_debug.c. Could you please send a delta patch against
tip/master?

Ingo