From: "Jan Beulich" <jbeulich@novell.com>
To: <robert.richter@amd.com>, "Ingo Molnar" <mingo@elte.hu>
Cc: <linux-kernel@vger.kernel.org>
Subject: patch "x86: MOVE PCI IO ECS code to x86/pci" breaks CPU hotplug
Date: Thu, 21 Aug 2008 13:45:20 +0100 [thread overview]
Message-ID: <48AD7F80.76E4.0078.0@novell.com> (raw)
Converting __cpuinit functions called out of init_amd() (and similar others)
to __init (and making them subject of xxx_initcall() handling isn't valid, as
they would no longer be called for hot plugged CPUs.
Further, since it's likely that in virtualized environments the MSR write
would at best be ignored, I'd also recommend using the fault-safe
accessors here *and* check that the bit actually got set before setting
PCI_HAS_IO_ECS (one would obviously have to BUG() when hot-plugged
CPUs fail to set the bit when those available at boot successfully did so).
Jan
next reply other threads:[~2008-08-21 12:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 12:45 Jan Beulich [this message]
2008-08-21 13:02 ` patch "x86: MOVE PCI IO ECS code to x86/pci" breaks CPU hotplug Ingo Molnar
2008-08-21 13:16 ` Robert Richter
2008-08-22 6:05 ` Ingo Molnar
2008-08-21 13:19 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2008-08-21 12:59 Jan Beulich
2008-08-21 13:29 ` Robert Richter
2008-08-21 16:25 ` Yinghai Lu
2008-08-21 16:46 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AD7F80.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox