From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756215AbYHUR4W (ORCPT ); Thu, 21 Aug 2008 13:56:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751963AbYHUR4J (ORCPT ); Thu, 21 Aug 2008 13:56:09 -0400 Received: from h155.mvista.com ([63.81.120.155]:62346 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751034AbYHUR4I (ORCPT ); Thu, 21 Aug 2008 13:56:08 -0400 Message-ID: <48ADAC45.7080505@ru.mvista.com> Date: Thu, 21 Aug 2008 21:56:21 +0400 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: khilman@deeprootsystems.com Cc: Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/18] ide: remove ide_setup_dma() References: <20080620213323.13202.71450.sendpatchset@localhost.localdomain> <20080620213350.13202.73557.sendpatchset@localhost.localdomain> <48ADA2DB.3060306@ru.mvista.com> In-Reply-To: <48ADA2DB.3060306@ru.mvista.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I wrote: >> Export sff_dma_ops and then remove ide_setup_dma(). >> There should be no functional changes caused by this patch. >> Signed-off-by: Bartlomiej Zolnierkiewicz >> Index: b/drivers/ide/arm/palm_bk3710.c >> =================================================================== >> --- a/drivers/ide/arm/palm_bk3710.c >> +++ b/drivers/ide/arm/palm_bk3710.c >> @@ -318,15 +318,14 @@ static u8 __devinit palm_bk3710_cable_de >> static int __devinit palm_bk3710_init_dma(ide_hwif_t *hwif, >> const struct ide_port_info *d) >> { >> - unsigned long base = >> - hwif->io_ports.data_addr - IDE_PALM_ATA_PRI_REG_OFFSET; >> - >> printk(KERN_INFO " %s: MMIO-DMA\n", hwif->name); >> >> if (ide_allocate_dma_engine(hwif)) >> return -1; >> >> - ide_setup_dma(hwif, base); >> + hwif->dma_base = hwif->io_ports.data_addr - >> IDE_PALM_ATA_PRI_REG_OFFSET; >> + >> + hwif->dma_ops = &sff_dma_ops; >> >> return 0; >> } > Unfortunately, this patch broke this driver: > drivers/ide/arm/palm_bk3710.c:327: error: ‘sff_dma_ops’ undeclared > (first use in this function). The declatation of sff_dma_ops should've > been surrounded by: > #ifdef CONFIG_BLK_DEV_IDEDMA_SFF > not by: > #ifdef CONFIG_BLK_DEV_IDEDMA_PCI > the same as its definition is in ide-dma.c... OK, Kevin Hilman said he's going to post a patch for this issue... MBR, Sergei