From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH 0 of 4] Xen spinlock updates and performance measurements
Date: Thu, 21 Aug 2008 13:17:56 -0700 [thread overview]
Message-ID: <48ADCD74.60304@goop.org> (raw)
In-Reply-To: <20080821121300.GA26397@elte.hu>
Ingo Molnar wrote:
> -tip testing found this build failure:
>
> arch/x86/xen/spinlock.c: In function ‘spin_time_start’:
> arch/x86/xen/spinlock.c:60: error: implicit declaration of function ‘xen_clocksource_read’
>
> i've excluded these new commits for now from tip/master - could you
> please send a delta fix against tip/x86/xen?
>
Make xen_clocksource_read non-static.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
---
arch/x86/xen/time.c | 4 +---
arch/x86/xen/xen-ops.h | 2 ++
2 files changed, 3 insertions(+), 3 deletions(-)
===================================================================
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -29,8 +29,6 @@
/* Xen may fire a timer up to this many ns early */
#define TIMER_SLOP 100000
#define NS_PER_TICK (1000000000LL / HZ)
-
-static cycle_t xen_clocksource_read(void);
/* runstate info updated by Xen */
static DEFINE_PER_CPU(struct vcpu_runstate_info, runstate);
@@ -213,7 +211,7 @@
return xen_khz;
}
-static cycle_t xen_clocksource_read(void)
+cycle_t xen_clocksource_read(void)
{
struct pvclock_vcpu_time_info *src;
cycle_t ret;
===================================================================
--- a/arch/x86/xen/xen-ops.h
+++ b/arch/x86/xen/xen-ops.h
@@ -2,6 +2,7 @@
#define XEN_OPS_H
#include <linux/init.h>
+#include <linux/clocksource.h>
#include <linux/irqreturn.h>
#include <xen/xen-ops.h>
@@ -33,6 +34,7 @@
void xen_init_irq_ops(void);
void xen_setup_timer(int cpu);
+cycle_t xen_clocksource_read(void);
void xen_setup_cpu_clockevents(void);
unsigned long xen_tsc_khz(void);
void __init xen_time_init(void);
next prev parent reply other threads:[~2008-08-21 20:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 0:02 [PATCH 0 of 4] Xen spinlock updates and performance measurements Jeremy Fitzhardinge
2008-08-21 0:02 ` [PATCH 1 of 4] xen: save previous spinlock when blocking Jeremy Fitzhardinge
2008-08-21 7:25 ` Jan Beulich
2008-08-21 0:02 ` [PATCH 2 of 4] xen: add debugfs support Jeremy Fitzhardinge
2008-08-21 0:02 ` [PATCH 3 of 4] xen: allow interrupts to be enabled while doing a blocking spin Jeremy Fitzhardinge
2008-08-21 7:29 ` [PATCH 3 of 4] xen: allow interrupts to be enabled while doing ablocking spin Jan Beulich
2008-08-21 0:02 ` [PATCH 4 of 4] xen: measure how long spinlocks spend blocking Jeremy Fitzhardinge
2008-08-21 11:53 ` [PATCH 0 of 4] Xen spinlock updates and performance measurements Ingo Molnar
2008-08-21 12:13 ` Ingo Molnar
2008-08-21 20:17 ` Jeremy Fitzhardinge [this message]
2008-08-22 6:09 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48ADCD74.60304@goop.org \
--to=jeremy@goop.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox