* [PATCH] V4L: fix return value of meye probe callback
@ 2008-08-22 20:13 Henne
0 siblings, 0 replies; only message in thread
From: Henne @ 2008-08-22 20:13 UTC (permalink / raw)
To: mchehab; +Cc: video4linux-list, linux-kernel
From: Henrik Kretzschmar <henne@nachtwindheim.de>
Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
The return vaule of the probe function should return -ENOMEM instead
of -EBUSY if video_device_alloc() fails.
diff --git a/drivers/media/video/meye.c b/drivers/media/video/meye.c
index 7c8ef6a..225714b 100644
--- a/drivers/media/video/meye.c
+++ b/drivers/media/video/meye.c
@@ -1774,6 +1774,7 @@ static int __devinit meye_probe(struct pci_dev *pcidev,
goto outnotdev;
}
+ ret = -ENOMEM;
meye.mchip_dev = pcidev;
meye.video_dev = video_device_alloc();
if (!meye.video_dev) {
@@ -1781,7 +1782,6 @@ static int __devinit meye_probe(struct pci_dev *pcidev,
goto outnotdev;
}
- ret = -ENOMEM;
meye.grab_temp = vmalloc(MCHIP_NB_PAGES_MJPEG * PAGE_SIZE);
if (!meye.grab_temp) {
printk(KERN_ERR "meye: grab buffer allocation failed\n");
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-08-22 20:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-22 20:13 [PATCH] V4L: fix return value of meye probe callback Henne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox