From: Avi Kivity <avi@qumranet.com>
To: Ingo Molnar <mingo@elte.hu>, Nick Piggin <npiggin@suse.de>
Cc: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: oops due to smp_call_function_single changes
Date: Sun, 24 Aug 2008 19:41:18 +0300 [thread overview]
Message-ID: <48B18F2E.8090108@qumranet.com> (raw)
My 2s x 2c Intel server (Xeon 5150) won't boot anymore. I bisected this to
commit cc7a486cac78f6fc1a24e8cd63036bae8d2ab431
Author: Nick Piggin <nickpiggin@yahoo.com.au>
Date: Mon Aug 11 13:49:30 2008 +1000
generic-ipi: fix stack and rcu interaction bug in
smp_call_function_mask()
* Venki Pallipadi <venkatesh.pallipadi@intel.com> wrote:
> Found a OOPS on a big SMP box during an overnight reboot test with
> upstream git.
>
> Suresh and I looked at the oops and looks like the root cause is in
> generic_smp_call_function_interrupt() and smp_call_function_mask()
with
> wait parameter.
>
[...]
Nice debugging work.
I'd suggest something like the attached (boot tested) patch as the
simple
fix for now.
I expect the benefits from the less synchronized,
multiple-in-flight-data
global queue will still outweigh the costs of dynamic allocations. But
if worst comes to worst then we just go back to a globally synchronous
one-at-a-time implementation, but that would be pretty sad!
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Reverting this commit (and cc7a486cac78f6fc1a24e8cd63036bae8d2ab431,
which is an add-on fix) allows my guest to boot.
My .config can be found in
http://userweb.kernel.org/~avi/scf-oops/config. I have an oops
somewhere inside a mobile phone but have yet to find a way to dig it
out. Netconsole doesn't work for me built-in for some reason, and this
is during boot (I think during the loading of the ahci modules).
--
error compiling committee.c: too many arguments to function
reply other threads:[~2008-08-24 16:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B18F2E.8090108@qumranet.com \
--to=avi@qumranet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox