public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Greg Ungerer <gerg@uclinux.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 11/23] m68knommu: use the new byteorder headers
Date: Mon, 25 Aug 2008 15:47:18 +1000	[thread overview]
Message-ID: <48B24766.8030700@snapgear.com> (raw)
In-Reply-To: <1219106888.17033.64.camel@brick>


Hi Harvey,

Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

Looks ok to me.

Acked-by: Greg Ungerer <gerg@uclinux.org>

Regards
Greg


>  arch/m68knommu/include/asm/byteorder.h |   13 +++++--------
>  1 files changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/m68knommu/include/asm/byteorder.h b/arch/m68knommu/include/asm/byteorder.h
> index 20bb442..6d9d3b8 100644
> --- a/arch/m68knommu/include/asm/byteorder.h
> +++ b/arch/m68knommu/include/asm/byteorder.h
> @@ -3,13 +3,11 @@
>  
>  #include <linux/types.h>
>  
> -#if defined(__GNUC__) && !defined(__STRICT_ANSI__) || defined(__KERNEL__)
> -#  define __BYTEORDER_HAS_U64__
> -#  define __SWAB_64_THRU_32__
> -#endif
> +#define __BIG_ENDIAN
> +#define __SWAB_64_THRU_32__
>  
>  #if defined (__mcfisaaplus__) || defined (__mcfisac__)
> -static inline __attribute_const__ __u32 ___arch__swab32(__u32 val)
> +static inline __attribute_const__ __u32 __arch_swab32(__u32 val)
>  {
>  	asm(
>  			"byterev %0"
> @@ -18,10 +16,9 @@ static inline __attribute_const__ __u32 ___arch__swab32(__u32 val)
>  	   );
>  	return val;
>  }
> -
> -#define __arch__swab32(x) ___arch__swab32(x)
> +#define __arch_swab32 __arch_swab32
>  #endif
>  
> -#include <linux/byteorder/big_endian.h>
> +#include <linux/byteorder.h>
>  
>  #endif /* _M68KNOMMU_BYTEORDER_H */


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     gerg@snapgear.com
SnapGear -- a Secure Computing Company      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com

      reply	other threads:[~2008-08-25  5:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-19  0:48 [PATCH 11/23] m68knommu: use the new byteorder headers Harvey Harrison
2008-08-25  5:47 ` Greg Ungerer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B24766.8030700@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=akpm@linux-foundation.org \
    --cc=gerg@uclinux.org \
    --cc=harvey.harrison@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox