* [PATCH -tip] rcuclassic: fix compiler warning
@ 2008-08-18 21:39 Hiroshi Shimamoto
2008-08-18 23:28 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Hiroshi Shimamoto @ 2008-08-18 21:39 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, H. Peter Anvin
Cc: Paul E. McKenney, linux-kernel
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
CC kernel/rcuclassic.o
kernel/rcuclassic.c: In function 'rcu_init_percpu_data':
kernel/rcuclassic.c:705: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:713: warning: comparison of distinct pointer types lacks a cast
flags should be unsigned long.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
kernel/rcuclassic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c
index fb1f1cc..86ff6d6 100644
--- a/kernel/rcuclassic.c
+++ b/kernel/rcuclassic.c
@@ -700,7 +700,7 @@ void rcu_check_callbacks(int cpu, int user)
static void rcu_init_percpu_data(int cpu, struct rcu_ctrlblk *rcp,
struct rcu_data *rdp)
{
- long flags;
+ unsigned long flags;
spin_lock_irqsave(&rcp->lock, flags);
memset(rdp, 0, sizeof(*rdp));
--
1.5.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -tip] rcuclassic: fix compiler warning
2008-08-18 21:39 [PATCH -tip] rcuclassic: fix compiler warning Hiroshi Shimamoto
@ 2008-08-18 23:28 ` Paul E. McKenney
2008-08-26 18:58 ` Hiroshi Shimamoto
0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2008-08-18 23:28 UTC (permalink / raw)
To: Hiroshi Shimamoto
Cc: Ingo Molnar, Thomas Gleixner, H. Peter Anvin, linux-kernel
On Mon, Aug 18, 2008 at 02:39:21PM -0700, Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> CC kernel/rcuclassic.o
> kernel/rcuclassic.c: In function 'rcu_init_percpu_data':
> kernel/rcuclassic.c:705: warning: comparison of distinct pointer types lacks a cast
> kernel/rcuclassic.c:713: warning: comparison of distinct pointer types lacks a cast
>
> flags should be unsigned long.
You beat me to it!
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> ---
> kernel/rcuclassic.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c
> index fb1f1cc..86ff6d6 100644
> --- a/kernel/rcuclassic.c
> +++ b/kernel/rcuclassic.c
> @@ -700,7 +700,7 @@ void rcu_check_callbacks(int cpu, int user)
> static void rcu_init_percpu_data(int cpu, struct rcu_ctrlblk *rcp,
> struct rcu_data *rdp)
> {
> - long flags;
> + unsigned long flags;
>
> spin_lock_irqsave(&rcp->lock, flags);
> memset(rdp, 0, sizeof(*rdp));
> --
> 1.5.6
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -tip] rcuclassic: fix compiler warning
2008-08-18 23:28 ` Paul E. McKenney
@ 2008-08-26 18:58 ` Hiroshi Shimamoto
2008-08-27 7:28 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Hiroshi Shimamoto @ 2008-08-26 18:58 UTC (permalink / raw)
To: Ingo Molnar; +Cc: paulmck, Thomas Gleixner, H. Peter Anvin, linux-kernel
Paul E. McKenney wrote:
> On Mon, Aug 18, 2008 at 02:39:21PM -0700, Hiroshi Shimamoto wrote:
>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>>
>> CC kernel/rcuclassic.o
>> kernel/rcuclassic.c: In function 'rcu_init_percpu_data':
>> kernel/rcuclassic.c:705: warning: comparison of distinct pointer types lacks a cast
>> kernel/rcuclassic.c:713: warning: comparison of distinct pointer types lacks a cast
>>
>> flags should be unsigned long.
>
> You beat me to it!
>
> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Hi Ingo, could you please apply this?
thanks,
Hiroshi Shimamoto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -tip] rcuclassic: fix compiler warning
2008-08-26 18:58 ` Hiroshi Shimamoto
@ 2008-08-27 7:28 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2008-08-27 7:28 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: paulmck, Thomas Gleixner, H. Peter Anvin, linux-kernel
* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> Paul E. McKenney wrote:
> > On Mon, Aug 18, 2008 at 02:39:21PM -0700, Hiroshi Shimamoto wrote:
> >> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> >>
> >> CC kernel/rcuclassic.o
> >> kernel/rcuclassic.c: In function 'rcu_init_percpu_data':
> >> kernel/rcuclassic.c:705: warning: comparison of distinct pointer types lacks a cast
> >> kernel/rcuclassic.c:713: warning: comparison of distinct pointer types lacks a cast
> >>
> >> flags should be unsigned long.
> >
> > You beat me to it!
> >
> > Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> Hi Ingo, could you please apply this?
hm, the fix got lost due to a revert+reapply - i've applied your fix
now, thanks for keeping an eye on it.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-27 7:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-18 21:39 [PATCH -tip] rcuclassic: fix compiler warning Hiroshi Shimamoto
2008-08-18 23:28 ` Paul E. McKenney
2008-08-26 18:58 ` Hiroshi Shimamoto
2008-08-27 7:28 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox