From: Andi Kleen <ak@linux.intel.com>
To: Daniel Walker <dwalker@mvista.com>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Matthew Wilcox <matthew@wil.cx>, Len Brown <len.brown@intel.com>,
Robert Moore <robert.moore@intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/4] mutex: add mutex_lock_timeout()
Date: Tue, 26 Aug 2008 21:32:24 +0200 [thread overview]
Message-ID: <48B45A48.6080604@linux.intel.com> (raw)
In-Reply-To: <1219777186-4787-1-git-send-email-dwalker@mvista.com>
Daniel,
My decision on this patchkit is to reject it for now, because:
- I'm worried about the long term maintenance impact of doing full
lockdep checking on AML controlled locks. Since I'm keeping ACPI
only temporarily I don't want to leave an potentially problematic
legacy.
- I fail to see the advantage of implementing semaphores using conditions.
However what you can do is to ask Len again when he's back. Ultimately
it is his decision and he might decide that he can deal with AML lockdep
issues longer term.
Don't think it makes all that much sense to resubmit the completion
patch though. It's unrelated to the other patches anyways (not sure
why you mix them together)
-Andi
next prev parent reply other threads:[~2008-08-26 19:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 18:59 [PATCH 1/4] mutex: add mutex_lock_timeout() Daniel Walker
2008-08-26 18:59 ` [PATCH 2/4] acpi: add real mutex function calls Daniel Walker
2008-08-26 18:59 ` [PATCH 3/4] acpi: add lockdep magic Daniel Walker
2008-08-26 18:59 ` [PATCH 4/4] acpi: semaphore removal Daniel Walker
2008-08-26 19:13 ` Matthew Wilcox
2008-08-26 19:30 ` Daniel Walker
2008-08-26 19:50 ` Matthew Wilcox
2008-08-26 20:03 ` Daniel Walker
2008-08-26 19:32 ` Andi Kleen [this message]
2008-08-26 19:51 ` [PATCH 1/4] mutex: add mutex_lock_timeout() Daniel Walker
2008-08-26 21:13 ` Andi Kleen
2008-08-26 22:09 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B45A48.6080604@linux.intel.com \
--to=ak@linux.intel.com \
--cc=dwalker@mvista.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.moore@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox