public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Claudio Scordino <claudio@evidence.eu.com>
To: Marc Pignat <marc.pignat@hevs.ch>
Cc: lg@denx.de, rmk+kernel@arm.linux.org.uk,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [ARM] Regression ? at91rm9200 machine-type
Date: Wed, 27 Aug 2008 12:09:39 +0200	[thread overview]
Message-ID: <48B527E3.6070204@evidence.eu.com> (raw)
In-Reply-To: <200808261443.12638.marc.pignat@hevs.ch>

Marc Pignat ha scritto:
> Hi!
> 
> On Tuesday 26 August 2008, you wrote:
>> Hi,
>>
>>     I have a custom board equivalent to AT91RM9200DK.
> If it is really equivalent, you can use the same MACH_TYPE, else you should
> register another.

I used the same MACH_TYPE.

> 
>> After commit
>>
>> 87fee013a23ad02821699aef5b76891b42959182
>>
>> [ARM] 4647/1: at91rm9200: Remove redundant machine-type verification
>> and manipulation
>>
>> I cannot boot my board anymore.
>>
>> Some more details:
>>   - I tried booting from both U-Boot 1.1.6 and U-Boot 1.3.4
>>   - I compiled U-Boot using "at91rm9200dk_config"
>>   - On U-Boot bootargs=console=ttyS0,115200 mem=32M
>> mtdparts=AT45DB642.spi0:-(filesystem) rootfstype=jffs2 root=/dev/mtdblock0
>>   - The .config of the kernel is in attachment
>>
>> I don't know if this is an actual regression or not (I'm not much
>> skilled in machine-types/boot process).
> 
> The "default machine" selection is a *hack* for machines with a bootloader too
> old, buggy or closed source.
> 
> The right fix is to change the MACH_TYPE that you've compiled in u-boot.
> 
>> However, it seems that the commit above, besides removing redundant 
>> machine type verification, removed the default machine type for 
>> unknown boards as well.
> 
> This is a cleanup patch, if the hack is not removed, bootloaders will *never*
> be fixed...

I see. Thank you for the explanations. Linux developers made things in
the right way by removing redundant machine type verification.

The bug is in U-Boot which passes the wrong mach type when compiled
for the at91rm9200dk board.

Many thanks for your quick answer.

              Claudio

-- 
Ing. Claudio Scordino		
Software Engineer, PhD
Tel. +39-050-5492050
http://retis.sssup.it/~scordino/

Evidence Srl
Embedded Real-Time Solutions
http://www.evidence.eu.com


  parent reply	other threads:[~2008-08-27 10:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 10:30 [ARM] Regression ? at91rm9200 machine-type Claudio Scordino
2008-08-26 12:43 ` Marc Pignat
2008-08-26 13:19   ` Russell King
2008-08-27 10:09   ` Claudio Scordino [this message]
2008-08-26 13:17 ` Ben Dooks
2008-08-27 10:09   ` Claudio Scordino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B527E3.6070204@evidence.eu.com \
    --to=claudio@evidence.eu.com \
    --cc=lg@denx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.pignat@hevs.ch \
    --cc=rmk+kernel@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox