* [PATCH 3/4] pid_ns: de_thread: kill the now unneeded ->child_reaper change
@ 2008-08-24 15:49 Oleg Nesterov
2008-08-27 2:31 ` Serge E. Hallyn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Oleg Nesterov @ 2008-08-24 15:49 UTC (permalink / raw)
To: Andrew Morton
Cc: Eric W. Biederman, Pavel Emelyanov, Robert Rex, Roland McGrath,
Serge Hallyn, Sukadev Bhattiprolu, linux-kernel
de_thread() checks if the old leader was the ->child_reaper, this is not
possible any longer. With the previous patch ->group_leader itself will
change ->child_reaper on exit.
>From now find_new_reaper() is the only function (apart from initialization)
which plays with ->child_reaper.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 2.6.27-rc4/fs/exec.c~3_EXEC 2008-07-30 13:12:47.000000000 +0400
+++ 2.6.27-rc4/fs/exec.c 2008-08-24 19:20:05.000000000 +0400
@@ -825,8 +825,6 @@ static int de_thread(struct task_struct
schedule();
}
- if (unlikely(task_child_reaper(tsk) == leader))
- task_active_pid_ns(tsk)->child_reaper = tsk;
/*
* The only record we have of the real-time age of a
* process, regardless of execs it's done, is start_time.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/4] pid_ns: de_thread: kill the now unneeded ->child_reaper change
2008-08-24 15:49 [PATCH 3/4] pid_ns: de_thread: kill the now unneeded ->child_reaper change Oleg Nesterov
@ 2008-08-27 2:31 ` Serge E. Hallyn
2008-08-27 11:38 ` Pavel Emelyanov
2008-08-27 18:04 ` sukadev
2 siblings, 0 replies; 4+ messages in thread
From: Serge E. Hallyn @ 2008-08-27 2:31 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Eric W. Biederman, Pavel Emelyanov, Robert Rex,
Roland McGrath, Sukadev Bhattiprolu, linux-kernel
Quoting Oleg Nesterov (oleg@tv-sign.ru):
> de_thread() checks if the old leader was the ->child_reaper, this is not
> possible any longer. With the previous patch ->group_leader itself will
> change ->child_reaper on exit.
Neat.
> >From now find_new_reaper() is the only function (apart from initialization)
> which plays with ->child_reaper.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Serge Hallyn <serue@us.ibm.com>
>
> --- 2.6.27-rc4/fs/exec.c~3_EXEC 2008-07-30 13:12:47.000000000 +0400
> +++ 2.6.27-rc4/fs/exec.c 2008-08-24 19:20:05.000000000 +0400
> @@ -825,8 +825,6 @@ static int de_thread(struct task_struct
> schedule();
> }
>
> - if (unlikely(task_child_reaper(tsk) == leader))
> - task_active_pid_ns(tsk)->child_reaper = tsk;
> /*
> * The only record we have of the real-time age of a
> * process, regardless of execs it's done, is start_time.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/4] pid_ns: de_thread: kill the now unneeded ->child_reaper change
2008-08-24 15:49 [PATCH 3/4] pid_ns: de_thread: kill the now unneeded ->child_reaper change Oleg Nesterov
2008-08-27 2:31 ` Serge E. Hallyn
@ 2008-08-27 11:38 ` Pavel Emelyanov
2008-08-27 18:04 ` sukadev
2 siblings, 0 replies; 4+ messages in thread
From: Pavel Emelyanov @ 2008-08-27 11:38 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Eric W. Biederman, Robert Rex, Roland McGrath,
Serge Hallyn, Sukadev Bhattiprolu, linux-kernel
Oleg Nesterov wrote:
> de_thread() checks if the old leader was the ->child_reaper, this is not
> possible any longer. With the previous patch ->group_leader itself will
> change ->child_reaper on exit.
>
>>From now find_new_reaper() is the only function (apart from initialization)
> which plays with ->child_reaper.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Pavel Emelyanov <xemul@openvz.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/4] pid_ns: de_thread: kill the now unneeded ->child_reaper change
2008-08-24 15:49 [PATCH 3/4] pid_ns: de_thread: kill the now unneeded ->child_reaper change Oleg Nesterov
2008-08-27 2:31 ` Serge E. Hallyn
2008-08-27 11:38 ` Pavel Emelyanov
@ 2008-08-27 18:04 ` sukadev
2 siblings, 0 replies; 4+ messages in thread
From: sukadev @ 2008-08-27 18:04 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Eric W. Biederman, Pavel Emelyanov, Robert Rex,
Roland McGrath, Serge Hallyn, linux-kernel
Oleg Nesterov [oleg@tv-sign.ru] wrote:
| de_thread() checks if the old leader was the ->child_reaper, this is not
| possible any longer. With the previous patch ->group_leader itself will
| change ->child_reaper on exit.
|
| >From now find_new_reaper() is the only function (apart from initialization)
| which plays with ->child_reaper.
|
| Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-27 18:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-24 15:49 [PATCH 3/4] pid_ns: de_thread: kill the now unneeded ->child_reaper change Oleg Nesterov
2008-08-27 2:31 ` Serge E. Hallyn
2008-08-27 11:38 ` Pavel Emelyanov
2008-08-27 18:04 ` sukadev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox