public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: split e820 reserved entries record to late
Date: Thu, 28 Aug 2008 13:29:48 -0700	[thread overview]
Message-ID: <48B70ABC.8010805@zytor.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0808281255200.3300@nehalem.linux-foundation.org>

Linus Torvalds wrote:
> 
> So e820 is fairly trustworthy, but we know that it will have various 
> random things marked as reserved because they are special in some way (but 
> we don't know _how_ they are special - they may well be real BAR's that 
> just have a fixed meaning to ACPI or whatever).
> 

My thinking is that if we run into a region which is reserved in e820 
but points to a real BAR, we would want to keep that BAR pinned, since a 
legitimate BIOS might use this mechanism to indicate that the device 
implemented by that BAR is used by SMM or ACPI.  If not, in most cases 
we will only have wasted some address space.  The sucky case, of course, 
would be an uninitialized BAR pointing into unusable address space which 
happens to be reserved in e820.  This seems very difficult to 
disambiguate from the above case through any algorithm that I can think of.

> Of course, I bet there will be cases where this causes problems. It feels 
> like we have _never_ worked around some PCI BAR allocation problem without 
> hitting another unexpected one..

I suspect that for any possible behaviour, there will be at least one 
system out there doing something broken for it :(

	-hpa

  parent reply	other threads:[~2008-08-28 20:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28 19:39 [PATCH] x86: split e820 reserved entries record to late Yinghai Lu
2008-08-28 20:05 ` Linus Torvalds
2008-08-28 20:19   ` Yinghai Lu
2008-08-28 20:29   ` H. Peter Anvin [this message]
2008-08-28 20:38     ` Linus Torvalds
2008-08-28 20:45       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B70ABC.8010805@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox