Re: [PATCH] mmc_block: use generic helper to print capacities

James Bottomley
2008-09-05T21:04:26Z

On Fri, 2008-09-05 at 22:52 +0200, Pierre Ossman wrote:
> On Fri, 05 Sep 2008 15:09:00 -0500
> James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>
> > On Sun, 2008-08-31 at 20:54 +0200, Pierre Ossman wrote:
> > > From: Pierre Ossman <drzeus@drzeus.cx>
> > >
> > > Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
> >
> > Did you want me to take this?
>
> That was the idea since it needed your helper.
>
> > It seems to depend on pieces of your mmc
> > tree, so I'd have to carry it in my post-merge tree.
> >
>
> Oh? There shouldn't be any changes around those chunks. What kind of
> problems are you seeing?

Oh ... your inline attached patch is actually whitespace broken (it has
spaces for tabs), which is why it doesn't apply. Sorry, that's the
first thing I usually check, I just skipped it in your case. Could you
resend it as an attachment?

Thanks,

James