Re: [PATCH 1/2] lib: add generic helper to print sizes rounded to the correct SI range

Andrew Morton
2008-09-03T15:59:22Z

On Wed, 03 Sep 2008 09:32:34 -0500 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> > > + snprintf(buf, len, "%lld%s%s", size, tmp, units_str[units][i]);
> >
> > Can't print a u64 - we don't know what type it has. It must be cast to
> > something, usually unsigned long long.
>
> I thought there was a patch from Matthew to move u64 to unsigned long
> long on all architectures, thus obviating this annoying conversion ...
> is that still wandering upstream, or has it been dropped?

It broke, and it needs vast numbers of conversions in the arch code.