linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Tejun Heo <tj@kernel.org>
Cc: device@lanana.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jens Axboe <jens.axboe@oracle.com>
Subject: Re: regarding major number of block extended devt
Date: Wed, 03 Sep 2008 09:57:11 -0700	[thread overview]
Message-ID: <48BEC1E7.2030306@zytor.com> (raw)
In-Reply-To: <48BEBF34.50006@kernel.org>

Tejun Heo wrote:
> Then, we're between the rock and hard place then as there also is a
> lot of code which assumes certain layout of sd or hd minor numbers.
> Keeping only the major numbers doesn't really resolve any problem.  It
> may be able to mask a few but that can be more harmful than helpful.
> 
> So, if a program expects certain major numbers, it won't be able to
> access the partitions which have overflowed to the extended area.  If
> a program uses udev or sys hierarchy to walk through devices, it will
> be able to use them all.  Isn't that much better than overflowing into
> the same major and hope that everything would work out okay?

Oh dear...

I just realized that you're talking about *partitions*, not *devices*. 
There is a metric boatload of code out there that assumes you can take a 
device number, mask off some number of bits, and reach the parent 
device.  They will generally do that without checking if they are right 
or not.

As such, you're liable to suffer corruption of unrelated devices.

In that sense, yes, a separate major will help somewhat.

	-hpa


  reply	other threads:[~2008-09-03 16:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-02 12:26 regarding major number of block extended devt Tejun Heo
2008-09-02 12:35 ` Tejun Heo
2008-09-02 20:16   ` H. Peter Anvin
2008-09-03  4:13     ` Tejun Heo
2008-09-03 16:12       ` H. Peter Anvin
2008-09-03 16:21         ` Tejun Heo
2008-09-03 16:27           ` H. Peter Anvin
2008-09-03 16:45             ` Tejun Heo
2008-09-03 16:57               ` H. Peter Anvin [this message]
2008-09-03 18:11               ` H. Peter Anvin
2008-09-04  0:25                 ` Tejun Heo
2008-09-04  0:28                   ` H. Peter Anvin
2008-09-04  0:35                     ` Tejun Heo
2008-09-04  0:43                       ` H. Peter Anvin
2008-09-04 11:50                   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BEC1E7.2030306@zytor.com \
    --to=hpa@zytor.com \
    --cc=device@lanana.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).