public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Manu Abraham <abraham.manu@gmail.com>
To: linux-kernel@vger.kernel.org, v4l-dvb-maintainer@linuxtv.org,
	akpm@linux-foundation.org
Subject: DVB Update [PATCH 25/31] multiproto tree
Date: Thu, 04 Sep 2008 22:42:01 +0400	[thread overview]
Message-ID: <48C02BF9.1080603@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

>From 14e80f303046a7750a6cfb2210bd8fe561f21a3a Mon Sep 17 00:00:00 2001
From: Manu Abraham <manu@linuxtv.org>
Date: Thu, 4 Sep 2008 14:36:16 +0200
Subject: [PATCH] DVB Optimization: enable gate in a
symmetric/disciplined way,
 rather than implementing different ways leading to confusion.

This allows multiple gate_enable/disable's in the tuner read/write
functions, thereby lesser number of I/O operations throughout,
eventually leading to better results. As a side effect for the demods
that detect the STOP bit for auto closing, the auto closing of the
gate can be avoided, thereby a minimal gain in disabling the auto detect
feature as well. Improves readability on the device control.

From: Manu Abraham <abraham.manu@gmail.com>
Signed-off-by: Manu Abraham <manu@linuxtv.org>

 dvb_frontend.c |    2 ++
 1 file changed, 2 insertions(+)

[-- Attachment #2: 25.patch --]
[-- Type: text/x-patch, Size: 1316 bytes --]

>From 14e80f303046a7750a6cfb2210bd8fe561f21a3a Mon Sep 17 00:00:00 2001
From: Manu Abraham <manu@linuxtv.org>
Date: Thu, 4 Sep 2008 14:36:16 +0200
Subject: [PATCH] DVB Optimization: enable gate in a symmetric/disciplined way,
 rather than implementing different ways leading to confusion.

This allows multiple gate_enable/disable's in the tuner read/write
functions, thereby lesser number of I/O operations throughout,
eventually leading to better results. As a side effect for the demods
that detect the STOP bit for auto closing, the auto closing of the
gate can be avoided, thereby a minimal gain in disabling the auto detect
feature as well. Improves readability on the device control.

From: Manu Abraham <abraham.manu@gmail.com>
Signed-off-by: Manu Abraham <manu@linuxtv.org>

diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index c54b12c..e2d929e 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -733,6 +733,8 @@ static void dvb_frontend_init(struct dvb_frontend *fe)
 	if (fe->ops.init)
 		fe->ops.init(fe);
 	if (fe->ops.tuner_ops.init) {
+		if (fe->ops.i2c_gate_ctrl)
+			fe->ops.i2c_gate_ctrl(fe, 1);
 		fe->ops.tuner_ops.init(fe);
 		if (fe->ops.i2c_gate_ctrl)
 			fe->ops.i2c_gate_ctrl(fe, 0);

                 reply	other threads:[~2008-09-04 18:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C02BF9.1080603@gmail.com \
    --to=abraham.manu@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox