From: Robert Hancock <hancockr@shaw.ca>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: joro@8bytes.org, linux-kernel@vger.kernel.org,
tony.luck@intel.com, iommu@lists.linux-foundation.org,
mingo@redhat.com, kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [PATCH 1/3] x86: remove the NULL device hack in dma-mapping.h
Date: Thu, 04 Sep 2008 17:53:19 -0600 [thread overview]
Message-ID: <48C074EF.6090209@shaw.ca> (raw)
In-Reply-To: <fa.3x55VLi/XqDV2PUAW3SsqCnCKh4@ifi.uio.no>
FUJITA Tomonori wrote:
> On Wed, 3 Sep 2008 22:01:14 +0200
> Joerg Roedel <joro@8bytes.org> wrote:
>
>> On Thu, Sep 04, 2008 at 03:04:23AM +0900, FUJITA Tomonori wrote:
>>> +static void *x86_swiotlb_alloc_coherent(struct device *dev, size_t size,
>>> + dma_addr_t *dma_handle, gfp_t gfp)
>>> +{
>>> + if (!dev) {
>>> + dev = &x86_dma_fallback_dev;
>>> + gfp |= GFP_DMA;
>>> + }
>> This really should be checked in the generic x86 dma_alloc_coherent
>> function.
>
> I don't think so. Any motherboards with the recent IOMMUs support ISA?
Probably some LPC devices on those boards..
next parent reply other threads:[~2008-09-04 23:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.Tx5o9n5qXlTiaMQNn2gICqrkVUA@ifi.uio.no>
[not found] ` <fa.RE+bYfvoWz/5NCC06intia3OFmo@ifi.uio.no>
[not found] ` <fa.kdqbjaJP+Pja+TaKDb/G9J79BTA@ifi.uio.no>
[not found] ` <fa.3x55VLi/XqDV2PUAW3SsqCnCKh4@ifi.uio.no>
2008-09-04 23:53 ` Robert Hancock [this message]
2008-09-03 15:03 [PATCH] swiotlb: fix dma_alloc_coherent allocation failures with swiotlb Joerg Roedel
2008-09-03 18:04 ` [PATCH 0/3] fix swiotlb allocation gfp flag FUJITA Tomonori
2008-09-03 18:04 ` [PATCH 1/3] x86: remove the NULL device hack in dma-mapping.h FUJITA Tomonori
2008-09-03 18:54 ` FUJITA Tomonori
2008-09-03 20:01 ` Joerg Roedel
2008-09-04 4:11 ` FUJITA Tomonori
2008-09-04 10:00 ` Joerg Roedel
2008-09-04 12:50 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C074EF.6090209@shaw.ca \
--to=hancockr@shaw.ca \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox