Re: [PATCH] ucb1400_ts depends SND_AC97_BUS

[Randy Dunlap <randy.dunlap@oracle.com>]

Takashi Iwai wrote:
> At Fri, 05 Sep 2008 12:32:32 -0400 (EDT),
> Nicolas Pitre wrote:
>> On Fri, 5 Sep 2008, Takashi Iwai wrote:
>>
>>> At Fri, 05 Sep 2008 10:52:25 -0400 (EDT),
>>> Nicolas Pitre wrote:
>>>> On Fri, 5 Sep 2008, Takashi Iwai wrote:
>>>>
>>>>>> This was fixed 2 years ago.  Who broke it this time?
>>>>> Oh, it must be me.
>>>> I think both your patch and the one I previously posted are needed.
>>> Could you repost?  I can't find it easily now.
> 
> Thanks.  For linux-next, yes, it's needed.  But it's not for 2.6.27.
> 
> Meanwhile, my fix should be included in 2.6.27 since it's a
> regression.
> 
> Randy, could you check whether these two patches fix your problem?
> I'll put my patch to my tree for the next pull request after your
> confirmation.

Yes, all fixed/good.  Thanks.


> Can Nicolas's patch be to input tree, or any other taker?
> 
> 
> thanks,
> 
> Takashi
> 
>> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
>> index 6e1e8c6..22cf319 100644
>> --- a/drivers/input/touchscreen/Kconfig
>> +++ b/drivers/input/touchscreen/Kconfig
>> @@ -219,7 +219,6 @@ config TOUCHSCREEN_ATMEL_TSADCC
>>  
>>  config TOUCHSCREEN_UCB1400
>>  	tristate "Philips UCB1400 touchscreen"
>> -	select AC97_BUS
>>  	depends on UCB1400_CORE
>>  	help
>>  	  This enables support for the Philips UCB1400 touchscreen interface.
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 5dba165..70355d3 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -52,6 +52,7 @@ config HTC_PASIC3
>>  
>>  config UCB1400_CORE
>>  	tristate "Philips UCB1400 Core driver"
>> +	select AC97_BUS
>>  	help
>>  	  This enables support for the Philips UCB1400 core functions.
>>  	  The UCB1400 is an AC97 audio codec.
>>
>>
>> Nicolas
>>