[PATCH] mm: ifdef Quicklists in /proc/meminfo

[PATCH] mm: ifdef Quicklists in /proc/meminfo

[Hugh Dickins]

A "Quicklists:          0 kB" line has just started appearing in
/proc/meminfo, but most architectures (including x86) don't have
them configured: may we please #ifdef it, like the highmem lines?

And those architectures which do have quicklists configured are
using them for page tables: so let's place it next to PageTables.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---

 fs/proc/proc_misc.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

--- 2.6.27-rc5-git/fs/proc/proc_misc.c.0	2008-09-03 07:32:07.000000000 +0100
+++ linux/fs/proc/proc_misc.c	2008-09-08 13:07:41.000000000 +0100
@@ -183,6 +183,9 @@ static int meminfo_read_proc(char *page,
 		"SReclaimable: %8lu kB\n"
 		"SUnreclaim:   %8lu kB\n"
 		"PageTables:   %8lu kB\n"
+#ifdef CONFIG_QUICKLIST
+		"Quicklists:   %8lu kB\n"
+#endif
 		"NFS_Unstable: %8lu kB\n"
 		"Bounce:       %8lu kB\n"
 		"WritebackTmp: %8lu kB\n"
@@ -190,8 +193,7 @@ static int meminfo_read_proc(char *page,
 		"Committed_AS: %8lu kB\n"
 		"VmallocTotal: %8lu kB\n"
 		"VmallocUsed:  %8lu kB\n"
-		"VmallocChunk: %8lu kB\n"
-		"Quicklists:   %8lu kB\n",
+		"VmallocChunk: %8lu kB\n",
 		K(i.totalram),
 		K(i.freeram),
 		K(i.bufferram),
@@ -216,6 +218,9 @@ static int meminfo_read_proc(char *page,
 		K(global_page_state(NR_SLAB_RECLAIMABLE)),
 		K(global_page_state(NR_SLAB_UNRECLAIMABLE)),
 		K(global_page_state(NR_PAGETABLE)),
+#ifdef CONFIG_QUICKLIST
+		K(quicklist_total_size()),
+#endif
 		K(global_page_state(NR_UNSTABLE_NFS)),
 		K(global_page_state(NR_BOUNCE)),
 		K(global_page_state(NR_WRITEBACK_TEMP)),
@@ -223,8 +228,7 @@ static int meminfo_read_proc(char *page,
 		K(committed),
 		(unsigned long)VMALLOC_TOTAL >> 10,
 		vmi.used >> 10,
-		vmi.largest_chunk >> 10,
-		K(quicklist_total_size())
+		vmi.largest_chunk >> 10
 		);
 
 		len += hugetlb_report_meminfo(page + len);

Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo

[Christoph Lameter]

Acked-by: Christoph Lameter <cl@linux-foundation.org>

Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo

[KOSAKI Motohiro]

> A "Quicklists:          0 kB" line has just started appearing in
> /proc/meminfo, but most architectures (including x86) don't have
> them configured: may we please #ifdef it, like the highmem lines?
> 
> And those architectures which do have quicklists configured are
> using them for page tables: so let's place it next to PageTables.
> 
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---

Oh, I see.
Thanks Hugh.

Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo

[H. Peter Anvin]

KOSAKI Motohiro wrote:
>> A "Quicklists:          0 kB" line has just started appearing in
>> /proc/meminfo, but most architectures (including x86) don't have
>> them configured: may we please #ifdef it, like the highmem lines?
>>
>> And those architectures which do have quicklists configured are
>> using them for page tables: so let's place it next to PageTables.
>>
>> Signed-off-by: Hugh Dickins <hugh@veritas.com>
>> ---
> 
> Oh, I see.
> Thanks Hugh.
> 
> Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

x86 *does* use quicklists, at least with PAE.

	-hpa

Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo

[Hugh Dickins]

On Mon, 8 Sep 2008, H. Peter Anvin wrote:
> 
> x86 *does* use quicklists, at least with PAE.

Are you harking back to the good old days of 2.6.24?
Or looking ahead to a bright new future?

There was a defect, in the TLB flushing sequence IIRC,
which got them kicked out in a hurry.  They might return
- but I think everybody would prefer to have a better way
of applying the existing allocators than this extra pool.

Hugh

Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo

[Jeremy Fitzhardinge]

H. Peter Anvin wrote:
> x86 *does* use quicklists, at least with PAE.

No, not for a while now.

    J

Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo

[H. Peter Anvin]

Jeremy Fitzhardinge wrote:
> H. Peter Anvin wrote:
>> x86 *does* use quicklists, at least with PAE.
> 
> No, not for a while now.

Sorry, stale cache...

	-hpa