Re: [PATCH 1/2] x86: Move VMX MSRs to msr-index.h

Avi Kivity
2008-09-10T14:30:27Z

Yang, Sheng wrote:
> On Tuesday 09 September 2008 21:47:03 Avi Kivity wrote:
>
>> Sheng Yang wrote:
>>
>>> They are hardware specific MSRs, and we would use them in virtualization
>>> feature detection later.
>>>
>>>
>>>
>>>
>>> -
>>> -#define MSR_IA32_FEATURE_CONTROL 0x3a
>>> #define MSR_IA32_FEATURE_CONTROL_LOCKED 0x1
>>> #define MSR_IA32_FEATURE_CONTROL_VMXON_ENABLED 0x
>>>
>> Might as well move these two bitmask definitions.
>>
>
> Um... I think it's better to leave them here, for the MSR_IA32_FEATURE_CONTROL
> is a MSR which can be put into msr-index.h, but the others are only bits of
> MSR...
>

The EFER bits are in msr-index.h, and I think the msr index in one file
and the bits in another detract from clarity.

--
error compiling committee.c: too many arguments to function