Re: [RFC][PATCH 0/2] x86: Add "virt flags"

Yang, Sheng
2008-09-09T03:29:16Z

On Tuesday 09 September 2008 01:17:02 H. Peter Anvin wrote:
> H. Peter Anvin wrote:
> > Ingo Molnar wrote:
> >> hm, i think extending the already existing flags category sounds like
> >> a better solution than the separate virtual CPU flags line in
> >> /proc/cpuinfo. We already have self-invented flag entries (such as
> >> X86_FEATURE_NOPL), and adding more for virtualization would be quite
> >> natural to do, as long as it's reasonably close to the meaning of a
> >> 'CPU feature'.
> >>
> >> Peter, what would be your preference?
> >
> > It probably makes sense to separate these out as a separate word,
> > especially if they come from the hardware in any reasonable way. But
> > yes, adding them to the feature array makes sense.
>
> Just to clarify:
>
> I'm suggesting adding these to the existing feature flags array, in a
> separate binary word.
>

Thanks! I will update the patch to add another category, and merge the array.

--
regards
Yang, Sheng
> -hpa