From: Atsuo Igarashi <atsuo_igarashi@tripeaks.co.jp>
To: jason.wessel@windriver.com
Cc: linux-kernel@vger.kernel.org,
Atsuo Igarashi <atsuo_igarashi@tripeaks.co.jp>,
Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Subject: [PATCH] kgdb: could not write to the last of valid memory with kgdb.
Date: Tue, 09 Sep 2008 09:04:48 +0900 [thread overview]
Message-ID: <48C5BDA0.90105@tripeaks.co.jp> (raw)
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
Hi,
I'm using i.MX31 ARM11 board which has 104Mbyte valid memory.
When I'd invoked a print command to write the last of valid memory from gdb,
there was no response from kgdb.
It seems that the following line causes this problem.
kernel/kgdb.c: write_mem_msg()
...
491 flush_icache_range(addr, addr + length + 1);
If the last byte of valid memory is specified, the last cache line and the next
cache line will be flushed by the ARM11 V6's function from flush_icache_range().
I'm not sure why the 2nd parameter has +1, I assume this +1 is unnecessary for
ARM11 V6's cache.
I send a patch to remove this +1, does anyone know necessity for other architectures?
Regards,
Signed-off-by Atsuo Igarashi <atsuo_igarashi@tripeaks.co.jp>
[-- Attachment #2: kgdb_write_mem_msg.diff --]
[-- Type: text/x-diff, Size: 415 bytes --]
kernel/kgdb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/kgdb.c b/kernel/kgdb.c
index eaa21fc..949806a 100644
--- a/kernel/kgdb.c
+++ b/kernel/kgdb.c
@@ -488,7 +488,7 @@ static int write_mem_msg(int binary)
if (err)
return err;
if (CACHE_FLUSH_IS_SAFE)
- flush_icache_range(addr, addr + length + 1);
+ flush_icache_range(addr, addr + length);
return 0;
}
next reply other threads:[~2008-09-09 0:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 0:04 Atsuo Igarashi [this message]
2008-09-09 13:14 ` [PATCH] kgdb: could not write to the last of valid memory with kgdb Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C5BDA0.90105@tripeaks.co.jp \
--to=atsuo_igarashi@tripeaks.co.jp \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox