Re: [PATCH 1/2] VMware guest detection for x86 and x86-64

Yan Li
2008-09-25T02:48:19Z

On Wed, Sep 24, 2008 at 07:23:25PM -0700, Greg KH wrote:
> On Wed, Sep 24, 2008 at 08:22:10PM +0800, Yan Li wrote:
> > Detects whether we are running as a VMware guest or not. Detection is
> > based upon DMI vendor string.
> >
> > It provides a function:
> > int is_vmware_guest(void)
> > that can be used easily to detect if we are running as a VMware guest
> > or not.
>
> Why do we need to do this within the kernel, what is that going to
> achieve?
>
> People can do this easily in userspace if they need to detect this, I
> think there's a patch for util-linux-ng adding such a simple utility
> that handles almost all of the known virtualization engines right now.

Hi Greg,

For me this is used in the next patch (for mtrr/main.c) to suppress an
unnecessary warning when running as a VMware guest:
http://lkml.org/lkml/2008/9/24/144

We already have code to suppress warning under KVM so the above patch
suppress warnings for VMware guest also.

H. Peter Anvin and Alok kataria are also proposing we may need a more
general approach for detecting hypervisors that can be used for some
other quirks.

Thanks.

--
Li, Yan