Re: [PATCH 1/2] VMware guest detection for x86 and x86-64

Alok kataria
2008-09-24T16:20:16Z

On Wed, Sep 24, 2008 at 7:23 AM, Yan Li <elliot.li.tech@gmail.com> wrote:
> On Wed, Sep 24, 2008 at 05:10:24PM +0300, Cristi Magherusan wrote:
>> On Wed, 2008-09-24 at 20:22 +0800, Yan Li wrote:
>> > Detects whether we are running as a VMware guest or not. Detection is
>> > based upon DMI vendor string.
>> >
>> > It provides a function:
>> > int is_vmware_guest(void)
>> > that can be used easily to detect if we are running as a VMware guest
>> > or not.
>>
>> We can also use this feature to force the HZ value to 100 or 250 at most
>> when running in a virtual environment, since VirtualBox had some issues
>> with this by taking a lot of CPU time when the HZ was set to 1000.
>
> That's good. But this function is used for detecting VMware guest
> only. Do you think VMware also suffers from this problem?
>

Hi Yan,

Thanks for doing this patch.
It would be really beneficial to detect if we are running on a
hypervisor in general. Though i think the approach should be more
generic, so that we have a common interface for all the hypervisors.
I have some patches which use "cpuid" to detect if we are running on a
hypevisor and use various cpuid leafs to get some hypervisor specific
info.
This CPUID interface will be available only in the newer (read,
Hardware version 7) version of VMware products. So still for the
products which don't use the newer hardware version, this patch is
helpful.

Btw, are you pushing these patches for the 2.6.27 release ? If this is
for the x86 tree(2.6.28) i think we should hold on, until i post the
proposal for the cpuid patches, so that we can unify this and have a
generic way to detect on which hypervisor are we running .

Thanks,
Alok
> --
> Li, Yan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>