From: Avi Kivity <avi@qumranet.com>
To: "Yang, Sheng" <sheng.yang@intel.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/2] x86: Extended cpuinfo to show virtualization HW features
Date: Tue, 09 Sep 2008 16:23:19 +0300 [thread overview]
Message-ID: <48C678C7.6010709@qumranet.com> (raw)
In-Reply-To: <200809091605.42121.sheng.yang@intel.com>
Yang, Sheng wrote:
>> it should go into intel_64.c and intel.c
>>
>> YH
>>
>
> Yeah, I've considered that, but seems duplicate for both files? The feature
> detection code is the same. Any way to merge them?
>
You could add another file (intel-vt.c) and #include or link it from
both intel.c and intel_64.c.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-09-09 13:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 6:54 [PATCH 0/2] Extend "flags" to contain HW virtualization info Sheng Yang
2008-09-09 6:54 ` [PATCH 1/2] x86: Move VMX MSRs to msr-index.h Sheng Yang
2008-09-09 6:54 ` [PATCH 2/2] x86: Extended cpuinfo to show virtualization HW features Sheng Yang
2008-09-09 7:52 ` Yinghai Lu
2008-09-09 8:05 ` Yang, Sheng
2008-09-09 13:23 ` Avi Kivity [this message]
2008-09-09 17:45 ` Yinghai Lu
2008-09-10 8:04 ` Ingo Molnar
2008-09-10 10:42 ` Yang, Sheng
2008-09-10 12:02 ` Ingo Molnar
2008-09-10 10:53 ` [PATCH 2/2] x86: Extended "flags" to show virtualization HW feature in /proc/cpuinfo Sheng Yang
2008-09-09 13:26 ` [PATCH 2/2] x86: Extended cpuinfo to show virtualization HW features Avi Kivity
2008-09-09 15:50 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C678C7.6010709@qumranet.com \
--to=avi@qumranet.com \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sheng.yang@intel.com \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox