From: roel kluin <roel.kluin@gmail.com>
To: linux-kernel@vger.kernel.org, mpjohn@us.ibm.com, paulus@samba.org
Subject: [PATCH] [CELL] oprofile: test for flag instead of negative on unsigned
Date: Tue, 09 Sep 2008 21:48:17 +0200 [thread overview]
Message-ID: <48C6D301.305@gmail.com> (raw)
In-Reply-To: <48C685F6.8020108@gmail.com>
vi arch/powerpc/oprofile/cell/vma_map.c +46
And you'll find this comment in vma_map_lookup():
Default the offset to the physical address + a flag value.
Addresses of dynamically generated code can't be found in the vma
map. For those addresses the flagged value will be sent on to
the user space tools so they can be reported rather than just
thrown away.
Returned is the flag value 0x10000000 + vma when not found.
The test for negative overlay_tbl_offset does not work
because it is unsigned.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/powerpc/oprofile/cell/vma_map.c b/arch/powerpc/oprofile/cell/vma_map.c
index fff6666..41e0c22 100644
--- a/arch/powerpc/oprofile/cell/vma_map.c
+++ b/arch/powerpc/oprofile/cell/vma_map.c
@@ -229,7 +229,7 @@ struct vma_to_fileoffset_map *create_vma_map(const struct spu *aSpu,
*/
overlay_tbl_offset = vma_map_lookup(map, ovly_table_sym,
aSpu, &grd_val);
- if (overlay_tbl_offset < 0) {
+ if (overlay_tbl_offset >= 0x10000000) {
printk(KERN_ERR "SPU_PROF: "
"%s, line %d: Error finding SPU overlay table\n",
__func__, __LINE__);
next prev parent reply other threads:[~2008-09-09 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 14:19 invalid tests on unsigned roel kluin
2008-09-09 9:15 ` Mikael Pettersson
2008-09-09 19:48 ` roel kluin [this message]
2008-09-09 20:48 ` [PATCH] [CELL] oprofile: test for flag instead of negative " Maynard Johnson
2008-09-09 21:10 ` invalid tests " roel kluin
2008-09-11 17:22 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C6D301.305@gmail.com \
--to=roel.kluin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpjohn@us.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox