* [PATCH] V4L/DVB (7725): cx23885: unsigned cx23417_mailbox cannot be negative
@ 2008-09-10 15:58 roel kluin
0 siblings, 0 replies; 2+ messages in thread
From: roel kluin @ 2008-09-10 15:58 UTC (permalink / raw)
To: hverkuil, mchehab, linux-kernel
Unsigned cx23417_mailbox cannot be negative
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/cx23885-417.c
index 8118091..f0f09aa 100644
--- a/drivers/media/video/cx23885/cx23885-417.c
+++ b/drivers/media/video/cx23885/cx23885-417.c
@@ -1028,12 +1028,13 @@ static int cx23885_initialize_codec(struct cx23885_dev *dev)
printk(KERN_ERR "%s() f/w load failed\n", __func__);
return retval;
}
- dev->cx23417_mailbox = cx23885_find_mailbox(dev);
- if (dev->cx23417_mailbox < 0) {
+ retval = cx23885_find_mailbox(dev);
+ if (retval < 0) {
printk(KERN_ERR "%s() mailbox < 0, error\n",
__func__);
return -1;
}
+ dev->cx23417_mailbox = retval;
retval = cx23885_api_cmd(dev, CX2341X_ENC_PING_FW, 0, 0);
if (retval < 0) {
printk(KERN_ERR
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] V4L/DVB (7725): cx23885: unsigned cx23417_mailbox cannot be negative
@ 2008-11-26 22:03 roel kluin
0 siblings, 0 replies; 2+ messages in thread
From: roel kluin @ 2008-11-26 22:03 UTC (permalink / raw)
To: hverkuil, mchehab; +Cc: linux-kernel, video4linux-list
Unsigned cx23417_mailbox cannot be negative
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
dev->cx23417_mailbox has type u32, see
vi drivers/media/video/cx23885/cx23885.h +330
cx23885_find_mailbox() returns int, see
vi drivers/media/video/cx23885/cx23885-417.c +832
diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/cx23885-417.c
index 8118091..f0f09aa 100644
--- a/drivers/media/video/cx23885/cx23885-417.c
+++ b/drivers/media/video/cx23885/cx23885-417.c
@@ -1028,12 +1028,13 @@ static int cx23885_initialize_codec(struct cx23885_dev *dev)
printk(KERN_ERR "%s() f/w load failed\n", __func__);
return retval;
}
- dev->cx23417_mailbox = cx23885_find_mailbox(dev);
- if (dev->cx23417_mailbox < 0) {
+ retval = cx23885_find_mailbox(dev);
+ if (retval < 0) {
printk(KERN_ERR "%s() mailbox < 0, error\n",
__func__);
return -1;
}
+ dev->cx23417_mailbox = retval;
retval = cx23885_api_cmd(dev, CX2341X_ENC_PING_FW, 0, 0);
if (retval < 0) {
printk(KERN_ERR
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-26 22:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-10 15:58 [PATCH] V4L/DVB (7725): cx23885: unsigned cx23417_mailbox cannot be negative roel kluin
-- strict thread matches above, loose matches on Subject: below --
2008-11-26 22:03 roel kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox