From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753879AbYIKGKx (ORCPT ); Thu, 11 Sep 2008 02:10:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751609AbYIKGKo (ORCPT ); Thu, 11 Sep 2008 02:10:44 -0400 Received: from charybdis-ext.suse.de ([195.135.221.2]:43107 "EHLO emea5-mh.id5.novell.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751483AbYIKGKn (ORCPT ); Thu, 11 Sep 2008 02:10:43 -0400 Message-ID: <48C8B661.1030508@suse.de> Date: Thu, 11 Sep 2008 10:10:41 +0400 From: Alexey Starikovskiy User-Agent: Thunderbird 2.0.0.16 (X11/20080724) MIME-Version: 1.0 To: Kevin Hao CC: ak@linux.intel.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 1/2] fix acpi ec read write bug References: <1221103065-9123-1-git-send-email-kexin.hao@windriver.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kevin Hao wrote: > Fill in command unit of transaction_data structure, otherwise > gpe_transaction will skip read or write instruction. > > Signed-off-by: Kevin Hao > --- > drivers/acpi/ec.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index bd3555c..0c65e82 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -240,6 +240,7 @@ static int acpi_ec_transaction_unlocked(struct acpi_ec *ec, u8 command, > } > atomic_set(&ec->irq_count, 0); > /* fill in transaction structure */ > + ec->t.command = command; > ec->t.wdata = wdata; > ec->t.wlen = wdata_len; > ec->t.rdata = rdata; NAK Command is filled in acpi_ec_write_command() in order to make window between start of the transaction and validity of the transaction data to the bare minimum.