From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756073AbYIKQIm (ORCPT ); Thu, 11 Sep 2008 12:08:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752294AbYIKQIe (ORCPT ); Thu, 11 Sep 2008 12:08:34 -0400 Received: from gw.goop.org ([64.81.55.164]:37517 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbYIKQIe (ORCPT ); Thu, 11 Sep 2008 12:08:34 -0400 Message-ID: <48C94280.8060608@goop.org> Date: Thu, 11 Sep 2008 09:08:32 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Andrew Morton CC: Ingo Molnar , Alex Nixon , Linux Kernel Mailing List , Benjamin Herrenschmidt Subject: Re: [PATCH 0/3] Globally defining phys_addr_t References: <48C8D76B.10901@goop.org> <20080911095311.GB7795@elte.hu> <20080911032058.538ceb7c.akpm@linux-foundation.org> In-Reply-To: <20080911032058.538ceb7c.akpm@linux-foundation.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > On Thu, 11 Sep 2008 11:53:11 +0200 Ingo Molnar wrote: > > >> * Jeremy Fitzhardinge wrote: >> >> >>> Hi Ingo, >>> >>> This is a repost of a little 3-patch series which Andrew has been >>> carrying in -mm. It cleans up the definition of phys_addr_t to make >>> it kernel-wide rather than x86-specific, and fixes up PFN_PHYS() to >>> use it to avoid address truncation. >>> >>> We currently have a few workarounds for this problem in the tree, but >>> Alex found another bug caused by PFN_PHYS(), so it's probably better >>> if you bring these patches into tip.git for now. >>> >>> PowerPC also defines a phys_addr_t with the same meaning as x86; the >>> powerpc arch maintainers are happy with these patches. >>> >> Andrew, are you fine with that approach too? >> > > spose so. These patches are the same as those in -mm (I checked). > > Still seems a bit odd to me that we're disallowing things like 32-bit > reosurces on >4G-memory-span machines. A resource_size_t is a > different (and narrower) concept from a physical address. > I don't mind much either way. I added that patch on suggestion from BenH, and don't really mind if it gets dropped. The first two are the really important ones. >> Also, i dont see Andrew's signoffs in the patches, and that's the true >> path of these patches which should be preserved: you => -mm => -tip. >> > > Not really. These went > > JF -> mm > > and > > JF -> you > > but whatever. > Yes, I just resent the same patches. But getting the ones blessed with -mm pee would be the best. J