From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756003AbYIKVHz@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756003AbYIKVHz (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Sep 2008 17:07:55 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753020AbYIKVHq
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 11 Sep 2008 17:07:46 -0400
Received: from gw.goop.org ([64.81.55.164]:51616 "EHLO mail.goop.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752392AbYIKVHp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Sep 2008 17:07:45 -0400
Message-ID: <48C9889B.7090901@goop.org>
Date: Thu, 11 Sep 2008 14:07:39 -0700
From: Jeremy Fitzhardinge <jeremy@goop.org>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: Yinghai Lu <yhlu.kernel@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org,
       Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table
References: <patchbomb.1220826072@localhost>	 <944fe7ea3da7707eb90f.1220826078@localhost>	 <20080907234418.GB26079@one.firstfloor.org>	 <48C46BCB.2060209@goop.org> <20080908142619.GA10580@elte.hu>	 <20080910115525.GA31692@elte.hu> <48C7FA91.9050302@goop.org> <86802c440809111334u6d6691c3sd83bcfddc83b1bbd@mail.gmail.com>
In-Reply-To: <86802c440809111334u6d6691c3sd83bcfddc83b1bbd@mail.gmail.com>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Yinghai Lu wrote:
> void __iomem *__init_refok
> acpi_os_map_memory(acpi_physical_address phys, acpi_size size)
> {
>         if (phys > ULONG_MAX) {
>                 printk(KERN_ERR PREFIX "Cannot map memory that high\n");
>                 return NULL;
>         }
>         if (acpi_gbl_permanent_mmap)
>                 /*
>                 * ioremap checks to ensure this is in reserved space
>                 */
>                 return ioremap((unsigned long)phys, size);
>         else
>                 return __acpi_map_table((unsigned long)phys, size);
> }
> EXPORT_SYMBOL_GPL(acpi_os_map_memory);
>
> void acpi_os_unmap_memory(void __iomem * virt, acpi_size size)
> {
>         if (acpi_gbl_permanent_mmap) {
>                 iounmap(virt);
>         }
> }
> EXPORT_SYMBOL_GPL(acpi_os_unmap_memory);
>
> just let acpi_os_unmap_memory to call __acpi_unmap_table...
>   

That was my first attempt.  Unfortunately a lot of the acpi code seems
pretty sloppy about unmapping its tables, and basically relies on
__acpi_map_table's current behaviour of removing the previous mapping
when creating the new mapping.

    J